Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify middleware #449

Merged
merged 9 commits into from
Feb 27, 2012
Merged

Minify middleware #449

merged 9 commits into from
Feb 27, 2012

Conversation

cweider
Copy link
Contributor

@cweider cweider commented Feb 14, 2012

This moves caching/gzipping into its own middleware. This simplifies Minify.js a lot and gets things ready for moving the packaging logic out and into its own middleware in this branch.

This is mostly just moving code. It would be nice if this could be replaced by separate (and existent) gzipping and caching middlewares.

Note: this caching layer also respects the expires header, so in development, it will be important to add "maxAge": 1 in settings.

@Pita
Copy link
Contributor

Pita commented Feb 14, 2012

Can you add the new setting into settings.json.template?

Also, I feel like this minify thing gets more and more owned by you. Can you add some more comments please?

@cweider
Copy link
Contributor Author

cweider commented Feb 20, 2012

@Pita, adjusted the settings template. Minify almost to the point of being stable – then I will get around to documenting it. After this branch it will be much simpler and easy to document.

Note: in a few branches from now versioning should probably be added to the asset URLs so that the 6 hour maxAge doesn’t cause issues when server-side code changes (and the maxAge can be raised to a year or longer).

@Pita Pita merged commit b661ef5 into ether:master Feb 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants