Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chain 31415 data to Wirex Pay #5901

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

rfortunatov
Copy link
Contributor

Hi. I'm working in Wirex company and we're launching a new product called Wirex Pay. We're on the final stage of launch and we've chosen chain id that was previously used by FIL Wallaby testnet. This testnet is not active anymore so I would like to ask to update this chain data to Wirex Pay.
https://github.com/filecoin-project/testnet-wallaby - here's official FIL repository stating that Wallaby was discontinued.
https://docs.wirexpaychain.com/tech/wirex-pay-chain - here's our product documentation.
Thanks in advance.

Copy link

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add redFlags - reusedChainId

@rfortunatov
Copy link
Contributor Author

you need to add redFlags - reusedChainId

Done

@themanofathousandfaces

This comment was marked as spam.

1 similar comment
@themanofathousandfaces

This comment was marked as spam.

@rfortunatov
Copy link
Contributor Author

@ligi I've added required red flag. Can we merge this?

@ligi ligi merged commit bb95b81 into ethereum-lists:master Sep 26, 2024
5 checks passed
Copy link

PR merged - please consider contributing some funds to lists.eth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants