Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zenchain Testnet and Mainnet to list #5908

Merged
merged 12 commits into from
Sep 30, 2024

Conversation

krisbitney
Copy link
Contributor

This PR adds the Zenchain Testnet network to the chain list. Thank you!

Copy link

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

@krisbitney krisbitney changed the title Add Zenchain Testnet to list Add Zenchain Testnet and Mainnet to list Sep 27, 2024
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 2 explorers are the same

@krisbitney
Copy link
Contributor Author

the 2 explorers are the same

Thanks. I removed the explorer from the mainnet entry.

The Zenchain mainnet does not yet exist. We are about to launch the testnet and we wanted to reserve the chain ID 8108 for the mainnet, which we expect to release in Q2 2025. If reserving the chain ID like that is not allowed, I can remove the mainnet JSON file altogether.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add status incubating to the chain that is not yet active

@krisbitney
Copy link
Contributor Author

please add status incubating to the chain that is not yet active

Thank you. This has been completed. I appreciate your time.

@ligi ligi merged commit 96b8db7 into ethereum-lists:master Sep 30, 2024
5 checks passed
Copy link

PR merged - please consider contributing some funds to lists.eth

@krisbitney krisbitney deleted the add-zenchain-testnet branch September 30, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants