-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Inco Rivest Testnet #6058
Conversation
You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review. |
4fa5cbd
to
eb2dba4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the data looks good, and the file is well-formatted.
Here are a few minor suggestions:
shortName
: Use "boba" as theshortName
, as it seems to be the most common and recognized abbreviation.rpc
: It might be helpful to add a secondary RPC URL as a backup in case the first one experiences downtime.faucets
: I noticed this is a mainnet chain. It might be beneficial to remove thefaucets
field or explicitly state "N/A" to avoid confusion.
eb2dba4
to
58e9ffb
Compare
@Dubersnack thank you for the swift review! I have fixed the icon dimension typo from previous test failure.
I'm sorry I don't recognise "boba", where are you getting this from? Open to suggestion on
This is not a mainnet, it is a testnet, if that's what you mean, the faucet is necessary/functional right now.
This is a centralised developer-preview testnet; the backup RPC instances we have are behind a load-balancer pointed to by that domain, so for this testnet that's as good as it gets :) |
Signed-off-by: Silas Davis <silas@inco.network>
58e9ffb
to
7e850ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit adds support for the Rivest testnet by including its chain ID, RPC URLs, faucet, and explorer information. It also correctly sets the slip44 value to 1. The information appears accurate and complete.
PR merged - please consider contributing some funds to lists.eth |
No description provided.