Skip to content
This repository has been archived by the owner on Apr 24, 2022. It is now read-only.

Small fixes #1222

Merged
merged 4 commits into from
Jun 5, 2018
Merged

Small fixes #1222

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c2fca3
By value parameters in EthStratumClient Constructor
AndreaLanfranchi Jun 5, 2018
ae2782c
Late binding of boost::acceptor
AndreaLanfranchi Jun 5, 2018
604e899
Implemented basic liveness check for Api Sever
AndreaLanfranchi Jun 5, 2018
6d582e1
In case of reception of unknown method respond back to issuer
AndreaLanfranchi Jun 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libpoolprotocols/stratum/EthStratumClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ static void diffToTarget(uint32_t *target, double diff)
}


EthStratumClient::EthStratumClient(boost::asio::io_service & io_service, int worktimeout, int responsetimeout, string const & email, bool const & submitHashrate) : PoolClient(),
EthStratumClient::EthStratumClient(boost::asio::io_service & io_service, int worktimeout, int responsetimeout, string email, bool submitHashrate) : PoolClient(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are passing std::string by value you should also move it later on in

m_email(std::move(email))

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually m_email should be no longer needed as it's a legacy of old -O argument.
Will drop it in next jobs.

m_worktimeout(worktimeout),
m_responsetimeout(responsetimeout),
m_io_service(io_service),
Expand Down
2 changes: 1 addition & 1 deletion libpoolprotocols/stratum/EthStratumClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class EthStratumClient : public PoolClient

typedef enum { STRATUM = 0, ETHPROXY, ETHEREUMSTRATUM } StratumProtocol;

EthStratumClient(boost::asio::io_service & io_service, int worktimeout, int responsetimeout, string const & email, bool const & submitHashrate);
EthStratumClient(boost::asio::io_service & io_service, int worktimeout, int responsetimeout, string email, bool submitHashrate);
~EthStratumClient();

void connect() override;
Expand Down