This repository has been archived by the owner on Apr 12, 2021. It is now read-only.
Disallow relayMessage to L2 to L1 Message Passer #360
Merged
+54
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurelian
force-pushed
the
feat/802/removeL2MessagePasser
branch
from
fbb2240
to
c6fc5bc
Compare
maurelian
commented
Apr 6, 2021
| @@ -159,7 +159,7 @@ contract OVM_ExecutionManager is iOVM_ExecutionManager, Lib_AddressResolver { | |||
| override | |||
| public | |||
| { | |||
| require(transactionContext.ovmNUMBER == 0, "Only be callable at the start of a transaction"); | |||
| require(transactionContext.ovmNUMBER == 0, "Only callable at the start of a transaction"); | |||
There was a problem hiding this comment.
Sneaking in a fix to this error message that has been bothering me for a while.
maurelian
commented
Apr 6, 2021
| * via this contract's replay function. | ||
| * @dev The L1 Cross Domain Messenger contract sends messages from L1 to L2, and relays messages from L2 onto L1. | ||
| * In the event that a message sent from L1 to L2 is rejected for exceeding the L2 epoch gas limit, it can be resubmitted | ||
| * via this contract's replay function. |
There was a problem hiding this comment.
Lots of whitespace fixes in this PR from the recently added editorConfig file.
maurelian
commented
Apr 6, 2021
| // a call from any L2 account. | ||
| if(_target == resolve("OVM_L2ToL1MessagePasser")){ | ||
| // Write to the successfulMessages mapping and return immediately. | ||
| successfulMessages[xDomainCalldataHash] = true; |
There was a problem hiding this comment.
One could argue against calling this a 'successful message', but I think preventing future attempts to relay it is the right move.
maurelian
force-pushed
the
feat/802/removeL2MessagePasser
branch
from
c6fc5bc
to
c2d8b0d
Compare
This change prevents call spoofing on L2. Adds a test based on logs and successfulMessages mapping.
maurelian
force-pushed
the
feat/802/removeL2MessagePasser
branch
from
c2d8b0d
to
ca563f4
Compare
maurelian
commented
Apr 6, 2021
Comment on lines
+179
to
+184
| const logs = ( | ||
| await Mock__OVM_L2ToL1MessagePasser.provider.getTransactionReceipt( | ||
| (await resProm).hash | ||
| ) | ||
| ).logs | ||
| expect(logs).to.deep.equal([]) |
There was a problem hiding this comment.
This check is an indirect way of verifying that "no call was made to the Message Passer", I would have preferred to use Mock__OVM_L2ToL1MessagePasser.smocked.passMessageToL1.calls.length === 0, but smock doesn't actually handle the case where no calls are made to a function. I spend some time on a fix, but other tests broke, so I went with this.
maurelian
force-pushed
the
feat/802/removeL2MessagePasser
branch
from
872c98f
to
54d138e
Compare
ben-chain
approved these changes
Apr 7, 2021
| // a call from any L2 account. | ||
| if(_target == resolve("OVM_L2ToL1MessagePasser")){ | ||
| // Write to the successfulMessages mapping and return immediately. | ||
| successfulMessages[xDomainCalldataHash] = true; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents call spoofing on L2.
Adds a test based on logs and successfulMessages mapping.