Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: execution layer sync for alternative clients #790

Conversation

mininny
Copy link
Contributor

@mininny mininny commented Jul 15, 2024

Description

A new l2.enginekind flag was added for op-node recently: ethereum-optimism/optimism#10767.
Setting this to the relevant engine client kind allows users to use snap sync (or execution-layer syncing to be more exact) on alternative clients like op-erigon and reth.

This PR adds a section about using this flag in the Using Snap Sync for Node Operators docs. It also adds usage of l2.enginekind to various places in the docs so that users can notice this flag more.

If you find other documentation that is more relevant for this change, please let me know! 😄

Tests
All changes are formatted and linted via pnpm.

Additional context
N/A

Metadata
N/A

@mininny mininny requested a review from a team as a code owner July 15, 2024 12:37
Copy link
Contributor

coderabbitai bot commented Jul 15, 2024

Walkthrough

These changes introduce a new configuration option --l2.enginekind=<value> in multiple documentation files, allowing node operators to specify the type of engine client (geth, reth, erigon) they wish to use. This addition enhances the flexibility of node configuration and management.

Changes

Files Change Summary
pages/builders/node-operators/configuration/base-config.mdx Introduced --l2.enginekind=geth in the op-node command configuration.
pages/builders/node-operators/configuration/consensus-config.mdx Added l2.enginekind option to specify engine client type; details provided on valid options and defaults.
pages/builders/node-operators/management/snap-sync.mdx Added configuration details for enabling execution layer sync for alternative clients like reth and op-erigon.
pages/builders/node-operators/tutorials/mainnet.mdx Introduced --l2.enginekind=geth option in the op-node command for the op-mainnet network.
words.txt Added enginekind to the list of words.

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8272eb2 and 86181d1.

Files selected for processing (5)
  • pages/builders/node-operators/configuration/base-config.mdx (1 hunks)
  • pages/builders/node-operators/configuration/consensus-config.mdx (1 hunks)
  • pages/builders/node-operators/management/snap-sync.mdx (1 hunks)
  • pages/builders/node-operators/tutorials/mainnet.mdx (1 hunks)
  • words.txt (1 hunks)
Files skipped from review due to trivial changes (1)
  • pages/builders/node-operators/tutorials/mainnet.mdx
Additional context used
Path-based instructions (3)
pages/builders/node-operators/management/snap-sync.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Use bold for prominence instead of all caps or italics.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
    "
pages/builders/node-operators/configuration/base-config.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Use bold for prominence instead of all caps or italics.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
    "
pages/builders/node-operators/configuration/consensus-config.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Use bold for prominence instead of all caps or italics.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
    "
LanguageTool
words.txt

[duplication] ~85-~85: Möglicher Tippfehler: ein Wort wird wiederholt
Context: ...precatedpersonal enablements enginekind Erigon erigon ETHERBASE etherbase ETHSTATS ethstats E...

(GERMAN_WORD_REPEAT_RULE)

pages/builders/node-operators/configuration/consensus-config.mdx

[style] ~238-~238: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... <Tabs.Tab>--l2.enginekind=geth</Tabs.Tab> <Tabs.Tab>`OP_NODE_L2_ENGINE_KIND=ge...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

Additional comments not posted (1)
words.txt (1)

85-85: LGTM!

The addition of the word enginekind is correct.

Tools
LanguageTool

[duplication] ~85-~85: Möglicher Tippfehler: ein Wort wird wiederholt
Context: ...precatedpersonal enablements enginekind Erigon erigon ETHERBASE etherbase ETHSTATS ethstats E...

(GERMAN_WORD_REPEAT_RULE)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 86181d1
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/669518064008ff000849e018
😎 Deploy Preview https://deploy-preview-790--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (5)
pages/builders/node-operators/management/snap-sync.mdx (3)

84-101: Ensure Consistency in Terminology

The term "execution-layer syncing" should be consistent throughout the documentation. Consider using "execution layer sync" without the hyphen for consistency.

- In addition to op-geth, you can enable execution-layer syncing with alternative execution clients such as `reth` and `op-erigon`.
+ In addition to op-geth, you can enable execution layer sync with alternative execution clients such as `reth` and `op-erigon`.

87-88: Clarify the Design and Requirements

The sentence "Unlike op-geth, reth and op-erigon are designed as archive nodes..." could be clearer about the requirements for these clients.

- Unlike `op-geth`, `reth` and `op-erigon` are designed as archive nodes, which means they require the complete history of the chain.
+ Unlike `op-geth`, `reth` and `op-erigon` are designed as archive nodes, meaning they require the complete history of the chain.

98-101: Improve Readability of Code Block Comments

The comments in the code block should be more descriptive for better readability.

- # for reth
+ # Enable execution layer sync for reth
- # for erigon
+ # Enable execution layer sync for erigon
pages/builders/node-operators/configuration/base-config.mdx (1)

162-163: Ensure Consistency in Configuration Options

The configuration options should be consistent with the rest of the documentation. Ensure the correct usage of the --syncmode and --l2.enginekind flags.

- --syncmode=execution-layer \
- --l2.enginekind=geth
+ --syncmode=execution-layer \\
+ --l2.enginekind=geth
pages/builders/node-operators/configuration/consensus-config.mdx (1)

232-240: Avoid Repetition in Documentation

The repetition of the word "engine" in successive sentences can be avoided for better readability.

- The kind of engine client, used to control the behavior of optimism in respect to different types of engine clients. Valid options: `geth`, `reth`, `erigon`. The default value is `geth`.
+ The kind of engine client used to control the behavior of optimism in respect to different types of clients. Valid options: `geth`, `reth`, `erigon`. The default value is `geth`.
Tools
LanguageTool

[style] ~238-~238: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... <Tabs.Tab>--l2.enginekind=geth</Tabs.Tab> <Tabs.Tab>`OP_NODE_L2_ENGINE_KIND=ge...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

@cpengilly cpengilly merged commit 65036ba into ethereum-optimism:main Jul 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants