Fetching PrivateKey from Environnement and Execute onchain transaction. #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to fetch the private-key from the env directly and remove the hardcoded dummy privatekey from the codebase.
This will make sure that the private key fetch is with the correct format.
Using the environnement variable
PSPEXECUTOR_MON_PRIVATE_KEY
like below:I also increase the robustness of the HTTP method
/api/psp_execution
to make sure only the exact amount of args are strictly necessary also added a protection again to large payload size (> 1MB) that was missing (added some tests accordingly).Tests
I have refactor and added some tests like:
TestCheckAndReturnPrivateKey()
: tests theCheckAndReturnPrivateKey()
function to ensure that it returns the correct private key or error for an incorrect private key provided.I have refactors also some previous tests to follow the current standard with
expectErr
instead ofwants
.