Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go-linter to the CI + Fix the previous Linting issues #62

Merged
merged 28 commits into from
Sep 24, 2024

Conversation

Ethnical
Copy link
Collaborator

@Ethnical Ethnical commented Sep 11, 2024

Description

This PR is adding the go-linter into the CI.
This will allow us to improve the code clarity each time we are pushing.
Before pushing the new linting we decided to clean the linting issues to avoid having the CI failing thanks @nodauf for his contribution here.

Tests
All tests have been down locally + into the current CI.

Metadata

Fixes #69

@Ethnical Ethnical reopened this Sep 16, 2024
@Ethnical Ethnical mentioned this pull request Sep 18, 2024
@nodauf nodauf mentioned this pull request Sep 18, 2024
@Ethnical Ethnical marked this pull request as ready for review September 19, 2024 08:09
@Ethnical Ethnical requested a review from a team as a code owner September 19, 2024 08:09
@Ethnical Ethnical added the do-not-merge do not merge label Sep 19, 2024
@Ethnical Ethnical changed the title WIP: Add linter CI Add linter CI Sep 19, 2024
@Ethnical Ethnical changed the title Add linter CI Add go-linter CI Sep 19, 2024
@Ethnical Ethnical changed the title Add go-linter CI Add go-linter to the CI Sep 19, 2024
@Ethnical Ethnical self-assigned this Sep 19, 2024
@Ethnical Ethnical changed the title Add go-linter to the CI Add go-linter to the CI Sep 22, 2024
@Ethnical Ethnical assigned Ethnical and raffaele-oplabs and unassigned Ethnical Sep 24, 2024
@Ethnical Ethnical removed the do-not-merge do not merge label Sep 24, 2024
Makefile Outdated Show resolved Hide resolved
Co-authored-by: Raffaele <151576068+raffaele-oplabs@users.noreply.github.com>
Copy link
Contributor

@raffaele-oplabs raffaele-oplabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ethnical Ethnical changed the title Add go-linter to the CI Add go-linter to the CI + Fix the previous Linting issues Sep 24, 2024
@Ethnical Ethnical merged commit b7f6953 into main Sep 24, 2024
9 checks passed
@Ethnical Ethnical deleted the ethni/add-linting-to-ci branch September 24, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI go-lint
3 participants