generated from ethereum-optimism/.github
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go-linter
to the CI + Fix the previous Linting issues
#62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethnical
force-pushed
the
ethni/add-linting-to-ci
branch
from
September 11, 2024 11:32
e88612a
to
202e0c6
Compare
Closed
Merged
…veness_expiration
Co-authored-by: Raffaele <151576068+raffaele-oplabs@users.noreply.github.com>
raffaele-oplabs
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ethnical
changed the title
Add
Add Sep 24, 2024
go-linter
to the CIgo-linter
to the CI + Fix the previous Linting issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is adding the
go-linter
into the CI.This will allow us to improve the code clarity each time we are pushing.
Before pushing the new linting we decided to clean the linting issues to avoid having the CI failing thanks @nodauf for his contribution here.
Tests
All tests have been down locally + into the current CI.
Metadata
Fixes #69