Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding faultproof-withdrawals monitoring #75

Merged
merged 57 commits into from
Oct 1, 2024

Conversation

raffaele-oplabs
Copy link
Contributor

faultproof-withdrawals replaces chain-mon faultproof-wd-mon.

The functionality is the same as faultproof-wd-mon, but embedded in monitorism.

A clear and concise description of the features you're adding in this pull request.

Tests

Tests are going to be added soon.

Additional context

Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

.gitignore Show resolved Hide resolved
Copy link
Collaborator

@Ethnical Ethnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiples comment has been sent through this first review. We should make sure we are following the correct standard for the name of the files also.

op-monitorism/cmd/monitorism/cli.go Outdated Show resolved Hide resolved
op-monitorism/cmd/monitorism/cli.go Outdated Show resolved Hide resolved
op-monitorism/cmd/monitorism/cli.go Outdated Show resolved Hide resolved
op-monitorism/withdrawals/bindings/binding.md Outdated Show resolved Hide resolved
op-monitorism/withdrawals/bindings/binding.md Outdated Show resolved Hide resolved
op-monitorism/faultproof_withdrawals/withdrawal_helper.go Outdated Show resolved Hide resolved
op-monitorism/faultproof_withdrawals/withdrawal_helper.go Outdated Show resolved Hide resolved
op-monitorism/faultproof_withdrawals/withdrawal_helper.go Outdated Show resolved Hide resolved
@Ethnical
Copy link
Collaborator

Ethnical commented Sep 24, 2024

We are missing few todos that I will put there to make sure we are aligned or wants to track:

  • Comments functions with go-docs standard.
  • Update the README global + the README of the faultproof-withdrawals
  • clean the code with the current suggestions.
    and then we should be able to merge 🚀
    Hope also the linter will help us to clean the code faster now.

@Ethnical Ethnical marked this pull request as ready for review September 25, 2024 08:51
@Ethnical Ethnical requested a review from a team as a code owner September 25, 2024 08:51
@Ethnical Ethnical marked this pull request as draft September 25, 2024 08:52
@Ethnical
Copy link
Collaborator

Ethnical commented Sep 30, 2024

CleanShot 2024-09-30 at 13 12 25@2x
If possible to change binding to BINDING.md for markdown.
optimismportal should be OptimismPortal.go
and the file in bindings in uppercase.

@Ethnical
Copy link
Collaborator

Ethnical commented Sep 30, 2024

We conclude that documentation will arrived later on, for this new monitor and some minors improvements for the metrics due to quick need to merge this PR!

@Ethnical Ethnical added the enhancement New feature or request label Sep 30, 2024
@raffaele-oplabs raffaele-oplabs marked this pull request as ready for review October 1, 2024 11:50
@Ethnical Ethnical self-requested a review October 1, 2024 12:43
Copy link
Collaborator

@Ethnical Ethnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🚀

@raffaele-oplabs raffaele-oplabs merged commit 59a99bd into main Oct 1, 2024
9 checks passed
@raffaele-oplabs raffaele-oplabs deleted the faultproof_withdrawals branch October 1, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants