-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding faultproof-withdrawals monitoring #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiples comment has been sent through this first review. We should make sure we are following the correct standard for the name of the files also.
We are missing few todos that I will put there to make sure we are aligned or wants to track:
|
We conclude that documentation will arrived later on, for this new monitor and some minors improvements for the metrics due to quick need to merge this PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go 🚀
faultproof-withdrawals replaces chain-mon faultproof-wd-mon.
The functionality is the same as faultproof-wd-mon, but embedded in monitorism.
A clear and concise description of the features you're adding in this pull request.
Tests
Tests are going to be added soon.
Additional context
Add any other context about the problem you're solving.
Metadata