p2p: add discv5 to the discmix to dial nodes with #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a change that needs to happen in upstream, or is this local to us? |
Also upstream, I'm discussing it with the maintainer of discv5. But no need to wait for upstream to get discv5 working in our devnets. |
trianglesphere
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
discmixthat the dial scheduler pulls enodes from was not getting node records from discv5.When discv4 is disabled, but discv5 is enabled, and operating on a private network (no public dns based discovery), the geth node was able to peer manually, and log things about discovery, but wasn't dialing discovered records.