superchain: beta feature flag for overriding chain-config with superchain-registry #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protolambda
force-pushed
the
chain-config-db
branch
from
85fa0a9
to
b21ac42
Compare
sebastianst
reviewed
Oct 4, 2023
sebastianst
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds chain-config override functionality, to upgrade existing chain configs (in DB, from previous runs) with the chain config as defined in the superchain-registry.
This is optional, and behind a beta feature-flag for rollout:
--beta.rollup.superchain-upgradesThis also fixes some formatting in the genesis config for CI, which appeared to be formatted incorrectly due to prior merges.
Tests
Test that with
overrides.ApplySuperchainUpgradesthe superchain-registry chain-configuration is applied to the local chain configuration.Metadata
Fix https://github.com/ethereum-optimism/client-pod/issues/73