post-Canyon receipt-root deposit tx hashing fix #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberto-bayardo
force-pushed
the
canyon/fix-receipt-hash
branch
5 times, most recently
from
0329e31
to
0810748
Compare
roberto-bayardo
changed the title
roberto-bayardo
force-pushed
the
canyon/fix-receipt-hash
branch
2 times, most recently
from
91e3800
to
d7b47ba
Compare
roberto-bayardo
force-pushed
the
canyon/fix-receipt-hash
branch
2 times, most recently
from
7d3c419
to
91ec9fe
Compare
trianglesphere
requested review from
trianglesphere,
ajsutton and
protolambda
roberto-bayardo
force-pushed
the
canyon/fix-receipt-hash
branch
from
91ec9fe
to
939a388
Compare
This was referenced Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the post-Canyon deposit tx receipt encoding for the receipt-root calculation to include the deposit nonce, while preserving old behavior for pre-Canyon deposit txs with deposit nonces. Adds an optional version number to the deposit receipt consensus encoding that is specified only after Canyon hardfork.
Tests
Added test to confirm that legacy behavior of EncodeIndex for post-Regolith / pre-Canyon receipt hashing is maintained, while the post-Canyon behavior correctly includes the nonce and matches the behavior of MarshalBinary.
Existing receipt tests that accepted deposit txs all extended to test receipts both with & without deposit receipt version.
Metadata