fix receipt json marshaling/unmarshaling #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberto-bayardo
force-pushed
the
fix-receipt-json
branch
2 times, most recently
from
b6880dc
to
5177cb8
Compare
Signed-off-by: Roberto Bayardo <roberto.bayardo@coinbase.com>
roberto-bayardo
force-pushed
the
fix-receipt-json
branch
from
5177cb8
to
622226d
Compare
trianglesphere
approved these changes
Oct 26, 2023
trianglesphere
merged commit e8f25a6
into
ethereum-optimism:optimism
3 of 4 checks passed
This was referenced Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make JSON marshaling/unmarshaling of receipts handle deposit nonce & new deposit receipt version.
"go generate" was used to regenerate gen_receipt_json.go which appeared to have been manually edited before.
Tests
modified receipt json marshal/unmarshal test to confirm receipt root computation is not affected by json encoding
Additional context
Looks like deposit nonce never was included in the json serialization of a deposit transaction, but since the value wasn't previously being used in receipt hash generation (due to a different bug) this wasn't ever detected.
Metadata