Prepare Holocene devnet & testnet release #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sebastianst
commented
Nov 13, 2024
sebastianst
commented
- Bumps supported ProtocolVersion to 9.0.0-rc.1 (9 for Holocene)
- Also bumps Go CI version to 1.22
* Bumps supported ProtocolVersion to 9.0.0-rc.1 (9 for Holocene) * Also bumps Go CI version to 1.22
sebastianst
requested review from
axelKingsley and
geoknee
and removed request for
axelKingsley
geoknee
approved these changes
Nov 13, 2024
axelKingsley
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
The changes look sound and match the described goals. The use of << >> looks correct from what I just researched for circleci config formatting, but I noticed in the examples there were spaces between the brackets and parameter << like.this >>. I think this is fine too though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.