core: fix call to post-validation evm message hook #437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The post-validation check was running even when the EVM aborted without returning an execution-result. E.g. this may happen during block-building, when a tx does not pass state-transition pre-checks, and inclusion is aborted.
This post-validation hook was only set when the experimental Interop fork functionality is enabled, and thus not a production issue for mainnet.
Tests
E2E tests hit block-building code-path, although with flakes. I'll look into regression-testing it, but creating a more deliberate version of it e.g. with an action-test might mean it ignores the tx before even running the pre-checks.
Additional context
Reported by @mslipper, example in: https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/72874/workflows/2ec0d66a-c736-4e19-ad98-031fb11428db/jobs/2986089/steps