clean up

packages/sdk/src/cross-chain-messenger.ts

@@ -1249,13 +1249,13 @@ export class CrossChainMessenger {
     const challengePeriod =
       oracleVersion === '1.0.0'
         ? // The ABI in the SDK does not contain FINALIZATION_PERIOD_SECONDS
-          // in OptimismPortal, so making an explicit call instead.
-          BigNumber.from(
-            await this.contracts.l1.OptimismPortal.provider.call({
-              to: this.contracts.l1.OptimismPortal.address,
-              data: '0xf4daa291', // FINALIZATION_PERIOD_SECONDS
-            })
-          )
+        // in OptimismPortal, so making an explicit call instead.
+        BigNumber.from(
+          await this.contracts.l1.OptimismPortal.provider.call({
+            to: this.contracts.l1.OptimismPortal.address,
+            data: '0xf4daa291', // FINALIZATION_PERIOD_SECONDS
+          })
+        )
         : await this.contracts.l1.L2OutputOracle.FINALIZATION_PERIOD_SECONDS()
     return challengePeriod.toNumber()
   }
@@ -1496,7 +1496,7 @@ export class CrossChainMessenger {
       // latest games are all invalid and the SDK would be forced to make a bunch of archive calls.
       for (let i = matches.length - 1; i > 0; i--) {
         const j = Math.floor(Math.random() * (i + 1))
-        ;[matches[i], matches[j]] = [matches[j], matches[i]]
+          ;[matches[i], matches[j]] = [matches[j], matches[i]]
       }
 
       // Now we verify the proposals in the matches array.
@@ -2308,12 +2308,6 @@ export class CrossChainMessenger {
 
       if (this.bedrock) {
         // get everything we need to finalize
-        const withdrawal = await this.toLowLevelMessage(resolved, messageIndex)
-        const xdmWithdrawal =
-          this.contracts.l1.L1CrossDomainMessenger.interface.decodeFunctionData(
-            'relayMessage',
-            withdrawal.message
-          )
         const messageHashV1 = hashCrossDomainMessagev1(
           resolved.messageNonce,
           resolved.sender,
@@ -2323,37 +2317,54 @@ export class CrossChainMessenger {
           resolved.message
         )
 
-        const isFailed =
-          await this.contracts.l1.L1CrossDomainMessenger.failedMessages(
+        // fetch the following
+        // 1. Whether it needs to be replayed because it failed
+        // 2. The withdrawal as a low level message
+        const [isFailed, withdrawal] = await Promise.allSettled([
+          this.contracts.l1.L1CrossDomainMessenger.failedMessages(
             messageHashV1
-          )
+          ),
+          this.toLowLevelMessage(resolved, messageIndex),
+        ])
 
-        // if failed we need to replay the message rather than finalizing it
-        if (isFailed === true) {
-          const tx =
-            await this.contracts.l1.L1CrossDomainMessenger.populateTransaction.relayMessage(
-              xdmWithdrawal._nonce,
-              xdmWithdrawal._sender,
-              xdmWithdrawal._target,
-              xdmWithdrawal._value,
-              xdmWithdrawal._minGasLimit,
-              xdmWithdrawal._message,
-              opts?.overrides || {}
-            )
-          return tx
+        // handle errors
+        if (
+          isFailed.status === 'rejected' ||
+          withdrawal.status === 'rejected'
+        ) {
+          const rejections = [isFailed, withdrawal]
+            .filter((p) => p.status === 'rejected')
+            .map((p: PromiseRejectedResult) => p.reason)
+          throw rejections.length > 1
+            ? new AggregateError(rejections)
+            : rejections[0]
         }
-        if ('todo remove me') {
-          throw new Error('should not be trying to finalize')
+
+        if (isFailed.value === true) {
+          const xdmWithdrawal =
+            this.contracts.l1.L1CrossDomainMessenger.interface.decodeFunctionData(
+              'relayMessage',
+              withdrawal.value.message
+            )
+          return this.contracts.l1.L1CrossDomainMessenger.populateTransaction.relayMessage(
+            xdmWithdrawal._nonce,
+            xdmWithdrawal._sender,
+            xdmWithdrawal._target,
+            xdmWithdrawal._value,
+            xdmWithdrawal._minGasLimit,
+            xdmWithdrawal._message,
+            opts?.overrides || {}
+          )
         }
 
         return this.contracts.l1.OptimismPortal.populateTransaction.finalizeWithdrawalTransaction(
           [
-            withdrawal.messageNonce,
-            withdrawal.sender,
-            withdrawal.target,
-            withdrawal.value,
-            withdrawal.minGasLimit,
-            withdrawal.message,
+            withdrawal.value.messageNonce,
+            withdrawal.value.sender,
+            withdrawal.value.target,
+            withdrawal.value.value,
+            withdrawal.value.minGasLimit,
+            withdrawal.value.message,
           ],
           opts?.overrides || {}
         )