Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ctb): mark coverage as successful if it fails with stack too deep #10008

Merged
merged 2 commits into from
Apr 1, 2024
Merged

test(ctb): mark coverage as successful if it fails with stack too deep #10008

merged 2 commits into from
Apr 1, 2024

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Apr 1, 2024

If coverage fails with an error containing stack too deep, it considers coverage as passing and logs a warning explaining why the job passed. Otherwise, coverage is marked as failing. This is intended to be a temporary measure to unblock #9839 until we resolve "stack too deep" issues in our codebase that occur when compiling with the optimizer off.

I will create a tracking issue with a plan for restoring coverage later today

@mds1 mds1 requested review from tynes and a team April 1, 2024 17:30
@codecov Codecov
Copy link

codecov bot commented Apr 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.36%. Comparing base (0832d78) to head (ac8740d).
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff              @@
##           develop   #10008       +/-   ##
============================================
- Coverage    42.52%   29.36%   -13.16%     
============================================
  Files           73       31       -42     
  Lines         4816     2884     -1932     
  Branches       759      607      -152     
============================================
- Hits          2048      847     -1201     
+ Misses        2662     1962      -700     
+ Partials       106       75       -31
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests 27.14% <ø> (ø)
common-ts-tests ?
contracts-ts-tests 12.25% <ø> (ø)
core-utils-tests ?
sdk-tests 40.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 42 files with indirect coverage changes

clabby
clabby approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. Wonder how many times I've overlooked this failing locally 🤔

@tynes tynes enabled auto-merge April 1, 2024 17:56
@tynes tynes mentioned this pull request Apr 1, 2024
Merged
@tynes tynes added this pull request to the merge queue Apr 1, 2024
@mds1 mds1 removed this pull request from the merge queue due to a manual request Apr 1, 2024
@mds1 mds1 enabled auto-merge April 1, 2024 18:05
@mds1 mds1 added this pull request to the merge queue Apr 1, 2024
Merged via the queue into develop with commit e61cd76 Apr 1, 2024
73 checks passed
@mds1 mds1 deleted the mds/disable-contract-coverage branch April 1, 2024 19:13
0xfuturistic pushed a commit that referenced this pull request Apr 1, 2024
@mds1 @0xfuturistic
test(ctb): mark coverage as successful if it fails with stack too deep (
32ff7ca 
#10008)

* test(ctb): mark coverage as successful if it fails with stack too deep

* Update packages/contracts-bedrock/package.json
0xfuturistic pushed a commit that referenced this pull request Apr 1, 2024
@mds1 @0xfuturistic
test(ctb): mark coverage as successful if it fails with stack too deep (
aba873c 
#10008)

* test(ctb): mark coverage as successful if it fails with stack too deep

* Update packages/contracts-bedrock/package.json
0xfuturistic pushed a commit that referenced this pull request Apr 1, 2024
@mds1 @0xfuturistic
test(ctb): mark coverage as successful if it fails with stack too deep (
f6e9a7c 
#10008)

* test(ctb): mark coverage as successful if it fails with stack too deep

* Update packages/contracts-bedrock/package.json
0xfuturistic added a commit that referenced this pull request Apr 1, 2024
@0xfuturistic
Squashed commit of the following:
11289db 
commit f753417
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Fri Mar 22 16:17:36 2024 -0500

    Update foundry.toml

commit ae9fdee
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Fri Mar 22 16:14:39 2024 -0500

    Squashed commit of the following:

    commit 7abd16d
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 21 15:14:52 2024 -0500

        contracts-bedrock: define new constant var for L1Block isInDependencySet selector

    commit 4855c3a
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 21 15:07:21 2024 -0500

        contracts-bedrock: downgrade pragma to 0.8.24 for CrossL2Inbox

    commit b2ad465
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Fri Mar 15 21:32:44 2024 -0500

        contracts-bedrock: add underscore to var in CrossL2Inbox

    commit 7fa84c4
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Fri Mar 15 20:10:05 2024 -0500

        contracts-bedrock: add vm.expectCall to CrossL2Inbox.t.sol

    commit e4d24c2
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Fri Mar 15 20:05:43 2024 -0500

        contracts-bedrock: update pragma to 0.8.24 for CrossL2Inbox

    commit 77c4973
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Fri Mar 15 18:31:18 2024 -0500

        contracts-bedrock: drop redundant lines in CrossL2Inbox.t.sol

    commit 8f18a60
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Fri Mar 15 18:25:29 2024 -0500

        op-bindings: make for CrossL2Inbox

    commit 845992b
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Fri Mar 15 18:25:03 2024 -0500

        contracts-bedrock: fix CrossL2Inbox.t.sol

    commit 5862234
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Fri Mar 15 18:18:31 2024 -0500

        contracts-bedrock: refactor CrossL2Inbox.t.sol

    commit 50d8ab5
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Fri Mar 15 18:12:38 2024 -0500

        contracts-bedrock: fix CrossL2Inbox.t.sol

    commit 31033e1
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Fri Mar 15 18:11:26 2024 -0500

        contracts-bedrock: add not entered errors to CrossL2Inbox.t.sol

    commit 4416d3f
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Fri Mar 15 18:11:14 2024 -0500

        contracts-bedrock: refactor CrossL2Inbox.t.sol

    commit eaf6ea9
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Fri Mar 15 18:10:58 2024 -0500

        contracts-bedrock: improve error in CrossL2Inbox

    commit 4e61ee4
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 17:26:46 2024 -0700

        contracts-bedrock: fix CrossL2Inbox.t.sol

    commit 69b3945
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 17:21:12 2024 -0700

        contracts-bedrock: add comment to CrossL2Inbox.t.sol

    commit 75b57ad
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 17:11:36 2024 -0700

        contracts-bedrock: use Predeploy in CrossL2Inbox.t.sol

    commit bc5750d
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 17:09:02 2024 -0700

        contracts-bedrock: define notEntered modifier

    commit d5a6ffe
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 17:04:44 2024 -0700

        contracts-bedrock: use Test instead of CommonTest with CrossL2Inbox.t.sol

    commit c7e303c
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 17:04:16 2024 -0700

        contracts-bedrock: change pragma to 0.8.24 for CrossL2Inbox.t.sol

    commit 1cb4137
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 16:49:32 2024 -0700

        contracts-bedrock: update snapshot for CrossL2Inbox

    commit 0c86ae4
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 16:48:28 2024 -0700

        contracts-bedrock: add sample vars to CrossL2Inbox.t.sol

    commit d8abd64
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 16:45:29 2024 -0700

        contracts-bedrock: update semver-lock for CrossL2Inbox

    commit 22c243a
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 16:43:09 2024 -0700

        op-bindings: make for CrossL2Inbox

    commit 4468c10
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 16:42:59 2024 -0700

        op-chain-ops: fix layer_two_test

    commit c2283dd
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 16:42:45 2024 -0700

        contracts-bedrock: fix CrossL2Inbox

    commit 7038fb7
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 15:52:43 2024 -0700

        contracts-bedrock: refactor CrossL2Inbox

    commit 509ed32
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 15:35:52 2024 -0700

        contracts-bedrock: remove unused code in CrossL2Inbox.t.sol

    commit 49d34be
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 15:35:12 2024 -0700

        contracts-bedrock: use kwargs in CrossL2Inbox.t.sol

    commit 1693066
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 15:33:00 2024 -0700

        contracts-bedrock: refactor testFuzz_executeMessage_succeeds

    commit dc55143
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 15:27:39 2024 -0700

        contracts-bedrock: rename from _storeCalldataID to _storeIdentifier in CrossL2Inbox

    commit edd074c
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 15:26:34 2024 -0700

        op-bindings: make for CrossL2Inbox

    commit 60a394a
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 14 15:26:23 2024 -0700

        contracts-bedrock: refactor tests for CrossL2Inbox

    commit 113e2ac
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Wed Mar 13 18:03:04 2024 -0700

        contracts-bedrock: fix CrossL2Inbox.t.sol

    commit 67d5469
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Wed Mar 13 18:02:58 2024 -0700

        contracts-bedrock: fix CrossL2Inbox

    commit f3ce399
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Wed Mar 13 16:20:14 2024 -0700

        contracts-bedrock: make ICrossL2Inbox interface of CrossL2Inbox.sol

    commit 42895a6
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Wed Mar 13 16:18:42 2024 -0700

        contracts-bedrock: make pragma exact for CrossL2Inbox.sol

    commit 1dfd83c
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Wed Mar 13 16:17:36 2024 -0700

        contracts-bedrock: create _callWithAllGas func in CrossL2Inbox.sol

    commit ec73dcd
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Wed Mar 13 15:46:20 2024 -0700

        contracts-bedrock: update interface name for L1Block in CrossL2Inbox

    commit 97ab5da
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Mon Mar 11 19:47:48 2024 -0700

        op-bindings: make for CrossL2Inbox

    commit 309dd6e
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Mon Mar 11 19:47:31 2024 -0700

        contracts-bedrock: make snapshots for CrossL2Inbox

    commit 53a1133
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Mon Mar 11 19:47:07 2024 -0700

        contracts-bedrock: update semver-lock for CrossL2Inbox

    commit 5f23dff
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Mon Mar 11 19:45:58 2024 -0700

        sdk: add CrossL2Inbox to contracts.ts

    commit 448142e
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Mon Mar 11 19:45:35 2024 -0700

        contracts-bedrock: add CrossL2Inbox to Predeploys.t.sol

    commit 5450d48
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Mon Mar 11 19:45:17 2024 -0700

        contracts-bedrock: add CrossL2Inbox to Setup.sol

    commit a70af74
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Mon Mar 11 19:44:53 2024 -0700

        contracts-bedrock: create tests CrossL2Inbox.sol

    commit 3edd198
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Mon Mar 11 19:44:37 2024 -0700

        contracts-bedrock: add CrossL2Inbox to Predeploys.sol

    commit 889ff4f
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Mon Mar 11 19:44:19 2024 -0700

        contracts-bedrock: create ICrossL2Inbox.sol

    commit 35fa4b5
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Mon Mar 11 19:44:04 2024 -0700

        contracts-bedrock: create CrossL2Inbox.sol

    commit c76eb5c
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Mon Mar 11 19:42:19 2024 -0700

        contracts-bedrock: add CrossL2Inbox to Artifacts.s.sol

    commit 56387cd
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Mon Mar 11 19:40:06 2024 -0700

        contracts-bedrock: set evm version to cancun

    commit ac7ae45
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Mon Mar 11 19:39:33 2024 -0700

        op-bindings: add CrossL2Inbox to addresses

    commit 423e7b4
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Mon Mar 11 19:38:29 2024 -0700

        op-bindings: add CrossL2Inbox to artifacts.json

commit 324f061
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Fri Mar 22 16:13:27 2024 -0500

    Squashed commit of the following:

    commit 6f2f000
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Thu Mar 21 16:35:41 2024 -0500

        op-chain-ops: fix layer_two_test.go

    commit 37e0582
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Wed Mar 13 17:45:59 2024 -0700

        contracts-bedrock: fix missing bracket in L2Genesis.s.sol

    commit 97255d1
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Tue Mar 12 12:28:17 2024 -0700

        contracts-bedrock: add L2ToL2CrossDomainMessenger to L2Genesis

    commit 74a2dc3
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Tue Mar 12 12:25:45 2024 -0700

        op-chain-ops: add L2ToL2CrossDomainMessenger to immutables_test

    commit 7f8a1d2
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Tue Mar 12 12:25:29 2024 -0700

        op-chain-ops: update value in layer_two_test

    commit 0dcac11
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Tue Mar 12 12:25:00 2024 -0700

        op-chain-ops: add L2ToL2CrossDomainMessenger to immutables

    commit e087e4c
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Tue Mar 12 12:24:49 2024 -0700

        op-chain-ops: add L2ToL2CrossDomainMessenger to genesis config

    commit 5a9cff5
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Tue Mar 12 11:43:54 2024 -0700

        contracts-bedrock: add CrossL2Inbox to L2Genesis

    commit 952fcf6
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Tue Mar 12 11:43:29 2024 -0700

        op-chain-ops: add CrossL2Inbox to immutables_test

    commit f49b346
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Tue Mar 12 11:43:21 2024 -0700

        op-chain-ops: add CrossL2Inbox to layer_two_test

    commit 73edb82
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Tue Mar 12 11:43:14 2024 -0700

        op-chain-ops: add CrossL2Inbox to immutables

    commit b761f46
    Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
    Date:   Tue Mar 12 11:42:44 2024 -0700

        op-chain-ops: add CrossL2Inbox to genesis config

commit 80c64ce
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Thu Mar 21 16:48:10 2024 -0500

    op-bindings: make for L2ToL2CrossDomainMessenger

commit 84aa493
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Thu Mar 21 16:34:18 2024 -0500

    op-bindings: make for L2ToL2CrossDomainMessenger

commit c501adb
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Thu Mar 21 16:18:12 2024 -0500

    contracts-bedrock: fix L2ToL2CrossDomainMessenger.t.sol

commit 8f0ffaa
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Thu Mar 21 16:18:04 2024 -0500

    contracts-bedrock: fix missing args for _storeMessageMetadata in L2ToL2CrossDomainMessenger

commit 277b6e2
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Thu Mar 21 15:07:55 2024 -0500

    contracts-bedrock: update pragma to 0.8.24 for L2ToL2CrossDomainMessenger

commit 74c99f8
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Fri Mar 15 21:33:22 2024 -0500

    contracts-bedrock: add underscore to var in L2ToL2CrossDomainMessenger

commit c796bc1
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Fri Mar 15 20:27:09 2024 -0500

    contracts-bedrock: split up assembly into functions in L2ToL2CrossDomainMessenger.sol

commit ff97c22
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Fri Mar 15 20:19:50 2024 -0500

    contracts-bedrock: add expectCall to L2ToL2CrossDomainMessenger.t.sol

commit 87f55d7
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Fri Mar 15 20:16:57 2024 -0500

    contracts-bedrock: add more checks to testFuzz_sendMessage_succeeds

commit 1111031
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Fri Mar 15 20:11:23 2024 -0500

    contracts-bedrock: update pragma to 0.8.25 for L2ToL2CrossDomainMessenger

commit a24c886
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Fri Mar 15 17:58:36 2024 -0500

    contracts-bedrock: add comment to L2ToL2CrossDomainMessenger.t.sol

commit a741d07
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Fri Mar 15 17:54:26 2024 -0500

    contracts-bedrock: add not entered tests for L2ToL2CrossDomainMessenger

commit e1b246c
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Fri Mar 15 17:54:19 2024 -0500

    contracts-bedrock: create custom error for NotEntered in L2ToL2CrossDomainMessenger

commit 32c9f6f
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Fri Mar 15 17:42:44 2024 -0500

    contracts-bedrock: update L2ToL2CrossDomainMessenger.t.sol to 0.8.24

commit a5798bb
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Fri Mar 15 17:25:48 2024 -0500

    contracts-bedrock: refactor L2ToL2CrossDomainMessenger.t.sol

commit c317685
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Fri Mar 15 17:25:35 2024 -0500

    op-bindings: make for L2ToL2CrossDomainMessenger

commit b225927
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Fri Mar 15 16:41:25 2024 -0500

    contracts-bedrock: add entered logic to L2ToL2CrossDomainMessenger.sol

commit 8ab4566
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Wed Mar 13 16:21:00 2024 -0700

    contracts-bedrock: use interface IL2ToL2CrossDomainMessenger for L2ToL2CrossDomainMessenger.sol

commit fb3b505
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Wed Mar 13 16:20:31 2024 -0700

    contracts-bedrock: make pragma exact for L2ToL2CrossDomainMessenger.sol

commit 5e83270
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Tue Mar 12 12:52:03 2024 -0700

    contracts-bedrock: add semver-lock for L2ToL2CrossDomainMessenger

commit 0b7a049
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Tue Mar 12 12:42:35 2024 -0700

    contracts-bedrock: use existing target in testFuzz_relayMessage_succeeds for L2ToL2CrossDomainMessenger

commit f935ca7
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Tue Mar 12 12:38:20 2024 -0700

    contracts-bedrock: make snapshots for L2ToL2CrossDomainMessenger

commit 48324ff
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Tue Mar 12 12:33:28 2024 -0700

    contracts-bedrock: create IL2ToL2CrossDomainMessenger.sol

commit e07ea99
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Tue Mar 12 12:30:47 2024 -0700

    contracts-bedrock: create tests for L2ToL2CrossDomainMessenger

commit 9c494f1
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Tue Mar 12 12:31:49 2024 -0700

    op-bindings: make for L2ToL2CrossDomainMessenger

commit 1a7ecd6
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Tue Mar 12 12:31:24 2024 -0700

    sdk: add L2ToL2CrossDomainMessenger to contracts.ts

commit dabc443
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Tue Mar 12 12:31:12 2024 -0700

    contracts-bedrock: add L2ToL2CrossDomainMessenger to Setup.sol

commit 23ffb1a
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Tue Mar 12 12:30:59 2024 -0700

    contracts-bedrock: add L2ToL2CrossDomainMessenger to Predeploys.t.sol

commit 9e3a2d1
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Tue Mar 12 12:29:36 2024 -0700

    contracts-bedrock: add L2ToL2CrossDomainMessenger to Predeploys.sol

commit 6f5689b
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Tue Mar 12 12:29:21 2024 -0700

    contracts-bedrock: create L2ToL2CrossDomainMessenger.sol

commit 29791ad
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Tue Mar 12 12:27:59 2024 -0700

    contracts-bedrock: add L2ToL2CrossDomainMessenger to Artifacts.s.sol

commit ae7a0a4
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Tue Mar 12 12:22:21 2024 -0700

    op-bindings: add L2ToL2CrossDomainMessenger to addresses.go

commit cb1d7fe
Author: Diego <105765223+0xfuturistic@users.noreply.github.com>
Date:   Tue Mar 12 12:21:53 2024 -0700

    op-bindings: add L2ToL2CrossDomainMessenger to artifacts.json

commit ef86c58
Author: carehabit <165479941+carehabit@users.noreply.github.com>
Date:   Tue Apr 2 04:58:20 2024 +0800

    all: use the built-in slices library (#10005)

    Signed-off-by: carehabit <shenyuting@outlook.com>

commit 28d5526
Author: refcell <abigger87@gmail.com>
Date:   Mon Apr 1 15:58:12 2024 -0400

    feat(op-dispute-mon): WithdrawalRequests Metrics (#9942)

    * feat(op-challenger): Delayed Weth Withdrawal Request Caller

    * fix(op-challenger): withdrawal request field ordering

    * fix(op-challenger): encapsulate delayed weth behind the fault dispute game contract binding

    * feat(op-dispute-mon): get withdrawals game caller method

    * fix(op-dispute-mon): revert service name changes

    * fix(op-dispute-mon): revert extractor test name

    * fix(op-dispute-mon): revert extractor changes

    * fix(op-dispute-mon): revert newline add

    * fix(op-dispute-mon): revert caller field reordering

    * feat(op-dispute-mon): weth caller creation and pass it through sub components

    * chore(op-dispute-mon): weth caller creation unit test

    * fix(op-dispute-mon): extractor test for weth caller creation error

    * feat(op-dispute-mon): wire up the withdrawals extractor

    * fix(op-dispute-mon): rebases

    * fix(op-dispute-mon): revert caller test change

    * fix(op-dispute-mon): recipient enricher

    * feat(op-dispute-mon): withdrawal request metrics

    * Update op-dispute-mon/mon/withdrawals.go

    Co-authored-by: Adrian Sutton <adrian@oplabs.co>

    * fix(op-dispute-mon): withdrawal request amounts

    ---------

    Co-authored-by: Adrian Sutton <adrian@oplabs.co>

commit c145ace
Author: refcell <abigger87@gmail.com>
Date:   Mon Apr 1 15:12:01 2024 -0400

    feat(op-dispute-mon): WithdrawalRequest and Recipients Enricher (#9940)

    * feat(op-challenger): Delayed Weth Withdrawal Request Caller

    * fix(op-challenger): withdrawal request field ordering

    * fix(op-challenger): encapsulate delayed weth behind the fault dispute game contract binding

    * feat(op-dispute-mon): get withdrawals game caller method

    * fix(op-dispute-mon): revert service name changes

    * fix(op-dispute-mon): revert extractor test name

    * fix(op-dispute-mon): revert extractor changes

    * fix(op-dispute-mon): revert newline add

    * fix(op-dispute-mon): revert caller field reordering

    * feat(op-dispute-mon): weth caller creation and pass it through sub components

    * chore(op-dispute-mon): weth caller creation unit test

    * fix(op-dispute-mon): extractor test for weth caller creation error

    * feat(op-dispute-mon): wire up the withdrawals extractor

    * fix(op-dispute-mon): rebases

    * fix(op-dispute-mon): revert caller test change

    * fix(op-dispute-mon): recipient enricher

commit f6e9a7c
Author: Matt Solomon <matt@mattsolomon.dev>
Date:   Mon Apr 1 11:56:56 2024 -0700

    test(ctb): mark coverage as successful if it fails with stack too deep (#10008)

    * test(ctb): mark coverage as successful if it fails with stack too deep

    * Update packages/contracts-bedrock/package.json

commit 3061d37
Author: refcell <abigger87@gmail.com>
Date:   Mon Apr 1 14:28:03 2024 -0400

    feat(op-dispute-mon): GetWithdrawals GameCaller Method (#9939)

    * feat(op-challenger): Delayed Weth Withdrawal Request Caller

    * fix(op-challenger): withdrawal request field ordering

    * fix(op-challenger): encapsulate delayed weth behind the fault dispute game contract binding

    * feat(op-dispute-mon): get withdrawals game caller method

    * fix(op-dispute-mon): revert service name changes

    * fix(op-dispute-mon): revert extractor test name

    * fix(op-dispute-mon): revert extractor changes

    * fix(op-dispute-mon): revert newline add

    * fix(op-dispute-mon): revert caller field reordering

    * fix(op-challenger): make contract method private

commit 6568308
Author: Kero <keroroxx520@gmail.com>
Date:   Tue Apr 2 01:28:05 2024 +0800

    indexer: update format string for uuid.UUID (#9772)

    * indexer: update format string for uuid.UUID

    The relayEvent variable is of type uuid.UUID, but it's being formatted as an
    integer (%d). This will cause a runtime error. Use %s to format the UUID as a
    string.

    * indexer: constraint l2_block_headers.timestamp > 0

    * indexer: doc bigint.Clamp assumption

commit 8b50c4d
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 1 16:51:14 2024 +0000

    build(deps): bump google.golang.org/protobuf in /op-ufm (#9854)

    Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0.

    ---
    updated-dependencies:
    - dependency-name: google.golang.org/protobuf
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit d825117
Author: Will Cory <willcory10@gmail.com>
Date:   Mon Apr 1 09:44:19 2024 -0700

    chore: Release new versions of all js packages (#9964)

    Co-authored-by: Will Cory <willcory@Wills-MacBook-Pro.local>

commit 7d93794
Author: Will Cory <willcory10@gmail.com>
Date:   Mon Apr 1 08:58:12 2024 -0700

    fix: make sdk-next tests run in ci (#10003)

    Co-authored-by: Will Cory <willcory@Wills-MacBook-Pro.local>
0xfuturistic pushed a commit that referenced this pull request Apr 24, 2024
@mds1 @0xfuturistic
test(ctb): mark coverage as successful if it fails with stack too deep (
fde1708 
#10008)

* test(ctb): mark coverage as successful if it fails with stack too deep

* Update packages/contracts-bedrock/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tynes tynes tynes approved these changes

@clabby clabby clabby approved these changes

@roninjin10 roninjin10 roninjin10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mds1 @tynes @clabby @roninjin10