Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump ci-builder to 0.47.0 #10126

Merged
merged 3 commits into from
Apr 12, 2024
Merged

ci: bump ci-builder to 0.47.0 #10126

merged 3 commits into from
Apr 12, 2024

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Apr 12, 2024

Description

Includes a new foundry version that fixes issues with generating
state dumps for kontrol integration.

#10125
https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/50797/workflows/a85a79de-a4a8-4820-9199-ded9ffe9de7d

Includes a new foundry version that fixes issues with generating
state dumps for kontrol integration.

#10125
https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/50797/workflows/a85a79de-a4a8-4820-9199-ded9ffe9de7d
@tynes tynes requested a review from a team as a code owner April 12, 2024 01:05
Copy link
Contributor

coderabbitai bot commented Apr 12, 2024

Walkthrough

The recent updates focus on enhancing code readability and consistency across several scripts and contracts within the Bedrock package. Changes include formatting adjustments such as proper indentation, removal of trailing commas, and correction of parentheses placement in function calls. These modifications aim to improve the clarity and maintainability of the code.

Changes

File Path Change Summary
.circleci/config.yml Updated ci_builder_image version from v0.46.1 to v0.47.0.
packages/.../Deploy.s.sol, packages/.../DeployPeriphery.s.sol, .../CrossDomainMessenger.sol, .../StandardBridge.sol, .../OptimistInviter.t.sol Adjusted indentation and parentheses placement for improved readability.
packages/.../DeployPeriphery.s.sol, .../Initializable.t.sol Removed trailing commas in abi.encode() calls.
packages/.../L1ERC721Bridge.t.sol, .../L2ERC721Bridge.t.sol Modified abi.encodeCall parameters to correct syntax errors.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tynes tynes requested a review from a team as a code owner April 12, 2024 01:25
@tynes tynes enabled auto-merge April 12, 2024 01:37
@tynes tynes added this pull request to the merge queue Apr 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 12, 2024
@tynes tynes added this pull request to the merge queue Apr 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 12, 2024
@tynes tynes added this pull request to the merge queue Apr 12, 2024
Merged via the queue into develop with commit 4aa875f Apr 12, 2024
72 checks passed
@tynes tynes deleted the feat/ci-builder-047 branch April 12, 2024 02:50
pcw109550 pushed a commit to testinprod-io/optimism that referenced this pull request Apr 15, 2024
* ci: bump ci-builder to 0.47.0

Includes a new foundry version that fixes issues with generating
state dumps for kontrol integration.

ethereum-optimism#10125
https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/50797/workflows/a85a79de-a4a8-4820-9199-ded9ffe9de7d

* lint: fix

* snapshots: update kontrol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants