-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdk: decouple from contracts-bedrock #10258
Conversation
Decouples the sdk from `contracts-bedrock` to enable it to easily be moved out of the monorepo. The foundry artifacts are build from 3fc229e and then copy/pasted into the sdk. There are no large breaking changes planned which is why this is safe to do. This sdk has already been replaced by viem and in the future a Go sdk can be broken out of the `op-e2e` package to serve as the reference implementation of a sdk. The typescript sdk will be subject to just work until new breaking changes are introduced but at that point we should have sufficient migration to the alternative solutions.
WalkthroughThis update involves modifying the import paths in several files within an SDK project. The changes switch from absolute to relative import paths, enhancing modularity and improving the maintainability of the codebase. This adjustment affects files related to both Ethereum (ETH) and ERC-20 token deposits. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10258 +/- ##
========================================
Coverage 42.40% 42.40%
========================================
Files 73 73
Lines 4830 4830
Branches 766 766
========================================
Hits 2048 2048
Misses 2676 2676
Partials 106 106
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tynes !
* sdk: decouple from contracts-bedrock Decouples the sdk from `contracts-bedrock` to enable it to easily be moved out of the monorepo. The foundry artifacts are build from 3fc229e and then copy/pasted into the sdk. There are no large breaking changes planned which is why this is safe to do. This sdk has already been replaced by viem and in the future a Go sdk can be broken out of the `op-e2e` package to serve as the reference implementation of a sdk. The typescript sdk will be subject to just work until new breaking changes are introduced but at that point we should have sufficient migration to the alternative solutions. * sdk: remove dead dep * deps: fix pnpm lock
Description
Decouples the sdk from
contracts-bedrock
to enableit to easily be moved out of the monorepo.
The foundry artifacts are build from 3fc229e and then
copy/pasted into the sdk. There are no large breaking changes
planned which is why this is safe to do. This sdk has already
been replaced by viem and in the future a Go sdk can be broken
out of the
op-e2e
package to serve as the reference implementationof a sdk.
The typescript sdk will be subject to just work until new breaking
changes are introduced but at that point we should have sufficient
migration to the alternative solutions.