-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block data migration #10813
Closed
Closed
Block data migration #10813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unnecessary jobs
Setting `open-pull-requests-limit: 0` prevent version updates but should keep the security scans and updates according to https://docs.github.com/en/code-security/dependabot/dependabot-security-updates/configuring-dependabot-security-updates#overriding-the-default-behavior-with-a-configuration-file > If you only require security updates and want to exclude version > updates, you can set open-pull-requests-limit to 0 in order to prevent > version updates for a given package-ecosystem.
* adding trivy scanning to the Docker files * adding docker build scan * fixing typo * adding context for bedrock images * adding context to ops dockerfile packages * fixing context for ops packges: * removing push/pull triggers and adding just a manual workflow run with workflow_dispatch
As far as I understand, all gas values are for the L1 transaction that submits the tx batches. Therefore, the fee currency can be set to `nil`.
* Add pages workflow and forkdiff config * Remove TODOs * Update trigger to reflect future celo default branch pattern * Update latest rebased commit
Remove common/interfaces/IExchange.sol (duplicate) We keep the one in the `mento` directory. Remove common/libraries/ReentrancyGuard.sol (duplicate) Directly use the original from OpenZeppelin.
This allows testing of newly deployed fee currencies even when MockSortedOracles is used. This is the some implementation used in celo-monorepo (except for updating it to a more recent solidity version).
so that BridgedETH and other bridged ERC20 tokens can be used as fee currencies. I won't included testing until the FeeCurrencyDirectory is ready.
to avoid using old 0.5 solidity versions.
Until we fix the errors caused by enabling it.
We need to include Celo's contracts in the count to make it succeed.
Co-authored-by: Mariano Cortesi <mcortesi@gmail.com>
Removes unused code, move code for better separation of concerns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports celo-org#121 over to celo6