Batcher: simplify ChannelOut initialization #12045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify the initialization of new
derive.ChannelOut
instances in the batcher. Includes:genesisTimestamp
andchainID
fromNewSpanChannelOut
(they are instead exposed from therollup.ChainSpec
structrollup.Config
variable to a reference inChannelBuilder
, to avoid the unnecessary referencing/dereferencing.Tests
There are no logic changes, apart from the
ChannelBuilder.rollupCfg
, which should be covered by existing tests.Additional context
Paving the way for customization of the derive.ChannelOut, which will come in a follow up.