fix: OPCM additional safety checks #12107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
blmalone
force-pushed
the
09-25-rename_proxyadminowner_-_superchainproxyadminowner
branch
from
19257da
to
0fca78a
Compare
blmalone
force-pushed
the
09-25-fix_opcm_additional_safety_checks
branch
from
3b2fff2
to
6a1395b
Compare
blmalone
force-pushed
the
09-25-rename_proxyadminowner_-_superchainproxyadminowner
branch
from
0fca78a
to
29b2268
Compare
blmalone
force-pushed
the
09-25-fix_opcm_additional_safety_checks
branch
from
6a1395b
to
c613757
Compare
mds1
approved these changes
Sep 25, 2024
blmalone
force-pushed
the
09-25-fix_opcm_additional_safety_checks
branch
from
c613757
to
6406848
Compare
Base automatically changed from
09-25-rename_proxyadminowner_-_superchainproxyadminowner
to
develop
September 25, 2024 19:28
blmalone
force-pushed
the
09-25-fix_opcm_additional_safety_checks
branch
from
6406848
to
537e30a
Compare
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looping back around to a
TODOcomment I left inDeployOPChain.s.sol. Added checks to make sure the OPCM proxy is correctly configured before returning the address to a user.