feat: Add FeeVaultConfigs arg to SystemConfig.init #12769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maurelian and the rest of your teammates on |
|
We could leave this out and just enforce that the first upgrade bundle also calls the setters atomically. Depending on the roles set in practice, it may not be possible |
maurelian
force-pushed
the
feat/isthmus-contracts
branch
2 times, most recently
from
c29c116
to
f06b10d
Compare
maurelian
force-pushed
the
feat/isthmus-contracts-setFeeVault
branch
from
c964f00
to
e88b9d9
Compare
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #12746, in order to keep that branch more stable.
feat: Add FeeVaultConfigs arg to SystemConfig.init
wip: Add FeeVaultConfigs to opcm
Add todo about doi iface types