[Batcher] Fix memory leak, reverse prepended blocks #12874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianBland
approved these changes
Nov 7, 2024
mdehoog
force-pushed
the
michael/batcher-leak
branch
from
5736a2a to
d7ecb46
Compare
geoknee
approved these changes
Nov 8, 2024
|
Thanks @mdehoog & apologies for this regression! |
GrapeBaBa
pushed a commit
to optimism-java/optimism
that referenced
this pull request
Nov 13, 2024
…m#12874) * Don't prepend blocks in reverse order * Fix memory leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#12810 removed the call to
removePendingChannelwhich is causing a memory leak in the batcher.Also revert the reverse ordering change introduced by that PR.
Tests
Tested by running the devnet locally, and checking the memory usage doesn't grow in pprof.
Additional context
We're seeing our batcher process OOM on Base Sepolia.