Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-chain-ops: Ignore messages from sources other than the L2XDM #4861

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

mslipper
Copy link
Collaborator

The relayMessage function on the message passer is public. To guard against spoofed withdrawals, we need to check the message's source to ensure that only messages from the L2XDM are included in the withdrawals migration.

Fixes CLI-3337
Fixes CLI-3331

@mslipper mslipper requested a review from a team as a code owner February 12, 2023 17:38
@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2023

⚠️ No Changeset found

Latest commit: be7524e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mslipper mslipper requested a review from tynes February 12, 2023 17:38
The `relayMessage` function on the message passer is public. To guard against spoofed withdrawals, we need to check the message's source to ensure that only messages from the L2XDM are included in the withdrawals migration.

Fixes CLI-3337
Fixes CLI-3331
@mslipper mslipper force-pushed the bugfix/check-messenger-addr-migration branch from fe588fb to be7524e Compare February 12, 2023 17:39
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #4861 (1c840c6) into develop (2c0ad57) will decrease coverage by 5.03%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4861      +/-   ##
===========================================
- Coverage    39.79%   34.77%   -5.03%     
===========================================
  Files          321      181     -140     
  Lines        19212    15123    -4089     
  Branches       761        0     -761     
===========================================
- Hits          7646     5259    -2387     
+ Misses       10996     9330    -1666     
+ Partials       570      534      -36     
Flag Coverage Δ
bedrock-go-tests 34.77% <0.00%> (-0.01%) ⬇️
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-chain-ops/genesis/migration/types.go 0.00% <0.00%> (ø)
...ontracts/contracts/libraries/rlp/Lib_RLPWriter.sol
...ontracts/contracts/L1/verification/BondManager.sol
...es/contracts-bedrock/contracts/L1/SystemConfig.sol
packages/core-utils/src/index.ts
...racts/contracts/libraries/utils/Lib_BytesUtils.sol
packages/core-utils/src/optimism/alias.ts
.../contracts/L1/messaging/L1CrossDomainMessenger.sol
packages/core-utils/src/common/bn.ts
...ts-bedrock/contracts/L2/L2CrossDomainMessenger.sol
... and 131 more

@mergify
Copy link
Contributor

mergify bot commented Feb 13, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Feb 13, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 38773bb into develop Feb 13, 2023
@mergify mergify bot deleted the bugfix/check-messenger-addr-migration branch February 13, 2023 17:07
@mergify mergify bot removed the on-merge-train label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants