fix(ctb): Loosen re-prove requirements in the OptimismPortal
#4866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4047259 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
…output root at the prior index
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4866 +/- ##
===========================================
- Coverage 39.78% 39.05% -0.74%
===========================================
Files 321 300 -21
Lines 19292 18663 -629
Branches 761 646 -115
===========================================
- Hits 7676 7288 -388
+ Misses 11046 10803 -243
- Partials 570 572 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
maurelian
reviewed
Feb 13, 2023
maurelian
approved these changes
Feb 13, 2023
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Loosens the requirements to re-prove a withdrawal transaction in the
OptimismPortalTests
Existing coverage for this change (output changed at same
l2OutputIndex):test_proveWithdrawalTransaction_replayProveChangedOutputRoot_succeedsNew tests for re-proving under a different
l2OutputIndex:test_proveWithdrawalTransaction_replayProveChangedOutputRootAndOutputIndex_succeedsMetadata
Fixes CLI-3332