-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contracts-bedrock: L2StandardBridge legacy withdraw
#4909
Conversation
|
94e5195
to
3ef44f2
Compare
Hey @tynes! This PR has merge conflicts. Please fix them before continuing review. |
Adds a test for the legacy withdraw functionality on the L2StandardBridge. Previously there were no tests for withdrawing ether via `withdraw`. This adds coverage. Also natspec is added to describe that these functions are not useful for being able to withdraw native L2 tokens. The modern functions must be used to withdraw native L2 tokens, the legacy functions assume that the withdrawal is working on a OptimismMintableERC20 token. Also regenerate the bindings for the slight change to the bytecode where we save a call in the withdrawal path if we don't need to make the call.
3ef44f2
to
972af58
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4909 +/- ##
==========================================
Coverage ? 39.81%
==========================================
Files ? 302
Lines ? 18920
Branches ? 646
==========================================
Hits ? 7533
Misses ? 10780
Partials ? 607
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
Adds a test for the legacy withdraw functionality on the L2StandardBridge. Previously there were no tests for withdrawing ether via
withdraw
. This adds coverage. Also natspec is added to describe that these functions are not useful for being able to withdraw native L2 tokens. The modern functions must be used to withdraw native L2 tokens, the legacy functions assume that the withdrawal is working on a OptimismMintableERC20 token.Also regenerate the bindings for the slight change to the bytecode where we save a call in the withdrawal path if we don't need to make the call.
Closes CLI-3333