Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: Return error when unmarshaling L1Info txs with invalid function selectors #4936

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

mslipper
Copy link
Collaborator

The function selector was not being checked on unmarshal, which allows for invalid block data to pass validation.

Fixes CLI-3389

@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2023

⚠️ No Changeset found

Latest commit: 16538ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@6da12c7). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 0eb020e differs from pull request most recent head 2554b43. Consider uploading reports for the commit 2554b43 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4936   +/-   ##
==========================================
  Coverage           ?   35.83%           
==========================================
  Files              ?      183           
  Lines              ?    15479           
  Branches           ?        0           
==========================================
  Hits               ?     5547           
  Misses             ?     9361           
  Partials           ?      571           
Flag Coverage Δ
bedrock-go-tests 35.83% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/rollup/derive/l1_block_info.go 80.18% <100.00%> (ø)

@mergify
Copy link
Contributor

mergify bot commented Feb 22, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Feb 22, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Feb 22, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Feb 22, 2023
@tynes
Copy link
Contributor

tynes commented Feb 22, 2023

Looks like this needs a rebase now

…ion selectors

The function selector was not being checked on unmarshal, which allows for invalid block data to pass validation.

Fixes CLI-3389
@mslipper
Copy link
Collaborator Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Feb 22, 2023

refresh

✅ Pull request refreshed

@mslipper mslipper merged commit a2db6ca into develop Feb 22, 2023
@mslipper mslipper deleted the feat/cli-3389 branch February 22, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants