Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-batcher/batcher/channel_manager: when send tx failed, the frame should strip the version #5050

Merged
merged 1 commit into from
Mar 4, 2023
Merged

op-batcher/batcher/channel_manager: when send tx failed, the frame should strip the version #5050

merged 1 commit into from
Mar 4, 2023

Conversation

s7v7nislands
Copy link
Contributor

@s7v7nislands s7v7nislands commented Mar 3, 2023 •
edited by sebastianst
Loading

Description

When send tx failed, the frame should strip the version. fix #4937

Metadata

@s7v7nislands s7v7nislands requested a review from a team as a code owner March 3, 2023 14:12
@s7v7nislands s7v7nislands requested a review from mslipper March 3, 2023 14:12
@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2023

⚠️ No Changeset found

Latest commit: 75db4d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mslipper mslipper requested a review from sebastianst March 3, 2023 15:02
sebastianst
sebastianst approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it hot-fixes the bug!

I'll work on a more maintainable refactor over the coming days that makes a clearer distinction between frame and tx data.

@mslipper mslipper merged commit 9024cf6 into ethereum-optimism:develop Mar 4, 2023
@s7v7nislands s7v7nislands deleted the fix_parse_frame_error branch March 5, 2023 02:15
@sebastianst sebastianst mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianst sebastianst sebastianst approved these changes

@mslipper mslipper Awaiting requested review from mslipper mslipper is a code owner automatically assigned from ethereum-optimism/go-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] op-node parse L1 batch data error: frameLength is too large: 2838834252
3 participants
@s7v7nislands @sebastianst @mslipper