Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op-node): Remove Deprecated Public rpc.Api Field #5712

Merged
merged 1 commit into from
May 15, 2023

Conversation

refcell
Copy link
Contributor

@refcell refcell commented May 15, 2023

Description

Removes the deprecated Public field in go-ethereum rpc.Api instantiation.

Reference: ethereum/go-ethereum#25059

@refcell refcell requested a review from a team as a code owner May 15, 2023 15:13
@refcell refcell requested a review from protolambda May 15, 2023 15:13
@changeset-bot
Copy link

changeset-bot bot commented May 15, 2023

⚠️ No Changeset found

Latest commit: 1d4a4c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@refcell refcell self-assigned this May 15, 2023
@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 1d4a4c1
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64624c1f258b65000765dc4e

@tynes
Copy link
Contributor

tynes commented May 15, 2023

Comment from go-ethereum

Public bool // deprecated - this field is no longer used, but retained for compatibility

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #5712 (1d4a4c1) into develop (c1b6240) will decrease coverage by 2.76%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5712      +/-   ##
===========================================
- Coverage    41.86%   39.10%   -2.76%     
===========================================
  Files          444      287     -157     
  Lines        29064    24429    -4635     
  Branches       868        0     -868     
===========================================
- Hits         12167     9554    -2613     
+ Misses       15952    13981    -1971     
+ Partials       945      894      -51     
Flag Coverage Δ
bedrock-go-tests 39.10% <ø> (+<0.01%) ⬆️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/node/server.go 56.66% <ø> (+1.11%) ⬆️

... and 158 files with indirect coverage changes

@OptimismBot OptimismBot merged commit 1382586 into develop May 15, 2023
@OptimismBot OptimismBot deleted the refcell/node/cleanup branch May 15, 2023 18:18
@mergify
Copy link
Contributor

mergify bot commented May 15, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 15, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants