-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): Add event filter params to sdk as options #6332
feat(sdk): Add event filter params to sdk as options #6332
Conversation
🦋 Changeset detectedLatest commit: 8003aa6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for opstack-docs canceled.
|
Hey @wilsoncusack! This PR has merge conflicts. Please fix them before continuing review. |
5e6f0f5
to
a333a2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There is currently no sane way to test the sdk in some cases, def talk to @roninjin10 about the sdk future, he made the sdk-next tests |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6332 +/- ##
===========================================
- Coverage 44.89% 44.88% -0.02%
===========================================
Files 449 449
Lines 29241 29244 +3
Branches 748 748
===========================================
- Hits 13128 13126 -2
- Misses 15046 15051 +5
Partials 1067 1067
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good call out @tynes! Would it be possible to add a test? There are existing sdk tests in packages/sdk/test-next/message-status.spec.ts
would just need to use any message from goerli/op-goerli older than the blocks we fork
9256679 for l1
11276409 for l2
Testing waitForMessageStatus is a little involved so maybe just test that getMessageStatus returns a tx when in the block range and then doesn't return a tx when the blockrange is outside of the block the tx is in |
Like a manual test or are you making real network calls in your tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roninjin10 could we get this merged pls 🙏 |
This PR has been added to the merge queue, and will be merged soon. |
Hey @wilsoncusack, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with |
Description
This PR adds optional args
fromBlockOrBlockHash
andtoBlockOrHash
togetMessageStatus
,getMessageReceipt
,waitForMessageReceipt
,waitForMessageStatus
, andestimateMessageWaitTimeSeconds
.This was motivated by having issues when bridging due to the massive block range.
Tests
I am not sure how we can test this. I ran the test suite locally. Maybe I can build the SDK from this branch in my project and try it?
Additional context
Add any other context about the problem you're solving.
Metadata