cleanup: port replica-healthcheck to chain-mon
#6438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for opstack-docs canceled.
|
This ports the `replica-healthcheck` service to the `chain-mon` package. The idea is that all of the simple typescript services that monitor the chain should live in the same package. This was the final package that was not following this standard. This way it will be easier to run the various monitoring services since they will all be the same docker image, given different entrypoints. It will also be easier to isolate and update the deps.
tynes
force-pushed
the
cleanup/replica-mon
branch
from
5f96f67 to
3d0178e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6438 +/- ##
===========================================
- Coverage 40.73% 40.72% -0.01%
===========================================
Files 465 465
Lines 33472 33472
Branches 1949 1949
===========================================
- Hits 13636 13633 -3
- Misses 18359 18364 +5
+ Partials 1477 1475 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
maurelian
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ports the
replica-healthcheckservice to thechain-monpackage. The idea is that all of the simple typescript services that monitor the chain should live in the same package. This was the final package that was not following this standard. This way it will be easier to run the various monitoring services since they will all be the same docker image, given different entrypoints. It will also be easier to isolate and update the deps.