Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txmgr: Increase default network timeout to 10s #6464

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

ajsutton
Copy link
Contributor

Description

Increase the default network timeout for transaction manager from 2s to 10s. Having requests time out too soon results in an increased failure rate and then the request is just retried, increasing load on the server and increasing chances of another time out.

@ajsutton ajsutton requested a review from a team as a code owner July 26, 2023 21:06
@ajsutton ajsutton requested a review from Inphi July 26, 2023 21:06
@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

⚠️ No Changeset found

Latest commit: 4278ac1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #6464 (4278ac1) into develop (e892e79) will increase coverage by 4.26%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6464      +/-   ##
===========================================
+ Coverage    40.61%   44.88%   +4.26%     
===========================================
  Files          465      403      -62     
  Lines        33472    27635    -5837     
  Branches      1949      260    -1689     
===========================================
- Hits         13595    12404    -1191     
+ Misses       18395    14152    -4243     
+ Partials      1482     1079     -403     
Flag Coverage Δ
bedrock-go-tests 43.92% <ø> (+<0.01%) ⬆️
cannon-go-tests 62.40% <ø> (ø)
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests 44.54% <ø> (+2.93%) ⬆️
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
op-service/txmgr/cli.go 64.33% <ø> (ø)

... and 68 files with indirect coverage changes

@OptimismBot OptimismBot merged commit 90111ed into develop Jul 26, 2023
@OptimismBot OptimismBot deleted the aj/increse-txmgr-timeout branch July 26, 2023 21:23
@mergify
Copy link
Contributor

mergify bot commented Jul 26, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jul 26, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants