Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate codechecks #784

Merged
merged 2 commits into from
May 6, 2021
Merged

Reinstate codechecks #784

merged 2 commits into from
May 6, 2021

Conversation

elenadimitrova
Copy link
Contributor

Undoes the temp removal of codechecks in #768 following a fix from maintainer

@elenadimitrova elenadimitrova self-assigned this May 6, 2021
@changeset-bot
Copy link

changeset-bot bot commented May 6, 2021

⚠️ No Changeset found

Latest commit: a78eb5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@elenadimitrova elenadimitrova marked this pull request as ready for review May 6, 2021 12:43
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2021

Codecov Report

Merging #784 (a78eb5c) into master (a0a0052) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #784   +/-   ##
=======================================
  Coverage   77.78%   77.78%           
=======================================
  Files          48       48           
  Lines        1886     1886           
  Branches      297      297           
=======================================
  Hits         1467     1467           
  Misses        419      419           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2ff66...a78eb5c. Read the comment docs.

@maurelian
Copy link
Contributor

Per the comment here, I think we'd need to install @codechecks/client@0.1.10-beta no?

Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming checks pass.

@elenadimitrova elenadimitrova merged commit 8168765 into master May 6, 2021
@elenadimitrova elenadimitrova deleted the reinstate-codechecks branch May 6, 2021 13:43
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
* Reinstate codechecks

* Upgrade to @codechecks/client@0.1.10-beta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants