Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ignore code coverage in script contracts #7992

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented Nov 1, 2023

We don't/can't generate code coverage for scripts so they should be ignored from the coverage report. Otherwise, updating contract scripts will fail the coverage diff check.

@mslipper mslipper added this pull request to the merge queue Nov 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2023
@Inphi
Copy link
Contributor Author

Inphi commented Nov 1, 2023

As a follow-up, Deploy.s.sol will be excluded from the ignore list once #7928 is merged.

@Inphi Inphi added this pull request to the merge queue Nov 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2023
@Inphi Inphi added this pull request to the merge queue Nov 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2023
@Inphi Inphi added this pull request to the merge queue Nov 2, 2023
Merged via the queue into develop with commit 2add4a5 Nov 2, 2023
57 checks passed
@Inphi Inphi deleted the inphi/cov-script branch November 2, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants