Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): have getMessageStatus call messenger #8212

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

smartcontracts
Copy link
Contributor

Description
getMessageStatus was previously using event queries to figure out the status of the given message. We can do the same thing by making requests directly to the messenger contracts which is more reliable because most RPC endpoints won't allow massive block ranges.x

getMessageStatus was previously using event queries to figure out the
status of the given message. We can do the same thing by making requests
directly to the messenger contracts which is more reliable because most
RPC endpoints won't allow massive block ranges.
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #8212 (fa6a233) into develop (ed2668a) will decrease coverage by 12.77%.
Report is 68 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #8212       +/-   ##
============================================
- Coverage    53.68%   40.92%   -12.77%     
============================================
  Files          162       27      -135     
  Lines         6072     1703     -4369     
  Branches       966      381      -585     
============================================
- Hits          3260      697     -2563     
+ Misses        2690     1006     -1684     
+ Partials       122        0      -122     
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests 26.95% <ø> (ø)
common-ts-tests ?
contracts-bedrock-tests ?
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests 42.18% <100.00%> (+0.23%) ⬆️
sdk-tests 42.18% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/sdk/src/cross-chain-messenger.ts 52.14% <100.00%> (+0.53%) ⬆️

... and 135 files with indirect coverage changes

Copy link
Contributor

semgrep-app bot commented Nov 21, 2023

Semgrep found 1 sol-style-notice-over-dev-natspec finding:

  • packages/contracts-bedrock/src/L1/SystemConfig.sol: L252

Prefer @dev over @notice in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

Semgrep found 1 sol-style-input-arg-fmt finding:

  • packages/contracts-bedrock/scripts/ChainAssertions.sol: L75

Inputs to functions must be prepended with an underscore (_)

Ignore this finding from sol-style-input-arg-fmt.

@smartcontracts smartcontracts marked this pull request as ready for review November 21, 2023 20:40
@smartcontracts smartcontracts requested a review from a team as a code owner November 21, 2023 20:40
@smartcontracts smartcontracts added this pull request to the merge queue Nov 21, 2023
Merged via the queue into develop with commit e38bad6 Nov 21, 2023
61 checks passed
@smartcontracts smartcontracts deleted the sc/get-message-status-fix branch November 21, 2023 22:04
@github-actions github-actions bot mentioned this pull request Nov 21, 2023
nitaliano pushed a commit that referenced this pull request May 20, 2024
…-fix

fix(sdk): have getMessageStatus call messenger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants