Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts-bedrock: bump forge-std 1fd874f0efdb711cb6807c4f4a000ed2805dc809 #9043

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jan 17, 2024

Description

Bumps forge-std to the latest commit that includes the vm.dumpState
cheatcode.

…dc809

Bumps `forge-std` to the latest commit that includes the `vm.dumpState`
cheatcode.

- foundry-rs/forge-std#499
- foundry-rs/foundry#6827
@tynes tynes requested a review from a team as a code owner January 17, 2024 18:06
@tynes tynes requested a review from Inphi January 17, 2024 18:06
Copy link
Contributor

coderabbitai bot commented Jan 17, 2024

Warning

Rate Limit Exceeded

@tynes has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 5 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 0376630 and 986b011.

Walkthrough

The update in the forge-std library within the contracts-bedrock package involves a shift in the Git submodule reference. This modification moves the submodule from an older commit to a newer one, potentially introducing various changes such as bug fixes, performance improvements, new features, or other updates that occurred between these two commit points in the repository.

Changes

Files Affected Summary of Changes
forge-std Submodule updated from commit 155d547 to 1fd874f.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6585b7c) 28.62% compared to head (986b011) 17.10%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #9043       +/-   ##
============================================
- Coverage    28.62%   17.10%   -11.53%     
============================================
  Files          166      118       -48     
  Lines         7213     4935     -2278     
  Branches      1234     1083      -151     
============================================
- Hits          2065      844     -1221     
+ Misses        5027     4016     -1011     
+ Partials       121       75       -46     
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests 27.14% <ø> (ø)
common-ts-tests ?
contracts-bedrock-tests 0.69% <ø> (ø)
contracts-ts-tests 12.25% <ø> (ø)
core-utils-tests ?
sdk-next-tests 42.08% <ø> (ø)
sdk-tests 42.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 48 files with indirect coverage changes

@tynes tynes added this pull request to the merge queue Jan 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2024
@tynes tynes added this pull request to the merge queue Jan 17, 2024
Merged via the queue into develop with commit a035ce9 Jan 17, 2024
69 checks passed
@tynes tynes deleted the ctb/forge-std-dep branch January 17, 2024 20:47
dshiell pushed a commit to polymerdao/optimism-dev that referenced this pull request Jan 22, 2024
…dc809 (ethereum-optimism#9043)

* contracts-bedrock: bump forge-std 1fd874f0efdb711cb6807c4f4a000ed2805dc809

Bumps `forge-std` to the latest commit that includes the `vm.dumpState`
cheatcode.

- foundry-rs/forge-std#499
- foundry-rs/foundry#6827

* contracts-bedrock: fix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants