Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove preinstall only-allow command from packages #9805

Merged

Conversation

alecananian
Copy link
Contributor

Description

  • Removes the preinstall scripts from package folders so that consumers of these packages are not forced into using pnpm
  • Leaves the preinstall script in the root package.json file so that contributors to this repository continue to be prompted to install with pnpm

Tests

No code changes

Metadata

Copy link
Contributor

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run pnpm run changeset from root of repo? Select @eth-optimism/sdk and update it a patch version with a message in past tense fixed issue with vercel builds failing on preinstall command

This will make it so the repo will release a new version with the change after this merges

Copy link
Contributor

coderabbitai bot commented Mar 11, 2024

Walkthrough

Walkthrough

The patch provided aims to resolve intermittent failures during the yarn install process for projects utilizing the @eth-optimism/sdk package, particularly when building on platforms like Vercel. The issue stemmed from the absence of the only-allow package or encountering a MODULE_NOT_FOUND error. The proposed fix involves including only-allow as a devDependency to ensure consistent installation success, thereby mitigating build failures.

Changes

File(s) Change Summary
.changeset/calm-boxes-do.md Patch introduced for @eth-optimism/sdk to tackle Vercel build issues.

Assessment against linked issues

Objective Addressed Explanation
Bug Description: only-allow not found / MODULE_NOT_FOUND (#9078)
Reproduce: Random yarn install failures (#9078)
Expected Behavior: Successful yarn install without errors (#9078)
Possible Fix: Adding only-allow as a devDependency (#9078)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

.changeset/calm-boxes-do.md Outdated Show resolved Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@roninjin10 roninjin10 added this pull request to the merge queue Mar 11, 2024
Merged via the queue into ethereum-optimism:develop with commit 3ccd12f Mar 11, 2024
69 checks passed
@github-actions github-actions bot mentioned this pull request Mar 11, 2024
nitaliano pushed a commit that referenced this pull request May 20, 2024
* remove preinstall only-allow command from packages

* add changeset

* Update .changeset/calm-boxes-do.md

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: Will Cory <willcory10@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

only-allow: not found / MODULE_NOT_FOUND
2 participants