-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove preinstall only-allow command from packages #9805
remove preinstall only-allow command from packages #9805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run pnpm run changeset
from root of repo? Select @eth-optimism/sdk
and update it a patch
version with a message in past tense fixed issue with vercel builds failing on preinstall command
This will make it so the repo will release a new version with the change after this merges
WalkthroughWalkthroughThe patch provided aims to resolve intermittent failures during the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
3ccd12f
* remove preinstall only-allow command from packages * add changeset * Update .changeset/calm-boxes-do.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: Will Cory <willcory10@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Description
preinstall
scripts from package folders so that consumers of these packages are not forced into usingpnpm
preinstall
script in the rootpackage.json
file so that contributors to this repository continue to be prompted to install withpnpm
Tests
No code changes
Metadata