-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contracts: More robust abi/storage snapshot gen #9950
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9950 +/- ##
============================================
+ Coverage 28.34% 42.67% +14.33%
============================================
Files 165 73 -92
Lines 7271 4794 -2477
Branches 1330 755 -575
============================================
- Hits 2061 2046 -15
+ Misses 5104 2642 -2462
Partials 106 106
Flags with carried forward coverage won't be shown. Click here to find out more. |
WalkthroughWalkthroughThe updates encompass significant changes to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
update geth version used by ci
packages/contracts-bedrock/scripts/autogen/generate-snapshots.ts
Outdated
Show resolved
Hide resolved
Semgrep found 1 Iteration over a possibly empty map |
Since #9950 kontrol tests have been consistently failing. There are a few theories as to why, but to fix tests in the meantime we will downgrade the version. It's possible this causes "llegal instruction" panics in some devnet tests, so let's try this, and incrementally increase the foundry version until we find a version that works for both until we properly debug the issues.
* contracts: More robust abi/storage snapshot gen * update geth version used by ci * ci: bump ci-builder rc * ci-builder: pin foundry commit, update nvm * ci: remove foundry commit pin, update foundry in versions.json * ci: bump ci-builder to v0.46.0-rc.4 * update Kontrol snapshots * set ast=true in foundry.toml; revert snapshot gen * replace Clone snapshots * enable --ast only during snapshots * reset snapshot directories * Update .circleci/config.yml to use ci-builder:v0.46.0 * update foundry to nightly-617dfc28cb8206a0003edcf73a6f1058adaef740 * ci: bump ci-builder to v0.46.1 --------- Co-authored-by: Roberto Bayardo <roberto.bayardo@coinbase.com> Co-authored-by: Sebastian Stammler <seb@oplabs.co>
Updates the generate-snapshot.ts script to be compatible with the latest forge artifact schema.
Note that the deleted snapshots referred to contracts that no longer exist.
Tested on foundry @
c2233ec9fe61e0920c61c6d779bc707252852037