Skip to content

Commit

Permalink
Specify fastlz version in specs
Browse files Browse the repository at this point in the history
  • Loading branch information
danyalprout committed May 2, 2024
1 parent 064677e commit 499210e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
4 changes: 2 additions & 2 deletions specs/fjord/derivation.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jq -r ".bytecode.object" packages/contracts-bedrock/forge-artifacts/GasPriceOrac
```

This transaction MUST deploy a contract with the following code hash
`0x17563a1e2f4faeee2c47abda44d74d8c91438c26f2f1ba774ef4e3c41cc45f3b`.
`0x58e192326ee67ed52b7add91e4640024cbd1b21528a0ff1e1d21b7ca54e3ee62`.

##### GasPriceOracle Proxy Update - Fjord

Expand Down Expand Up @@ -113,7 +113,7 @@ A deposit transaction is derived with the following attributes:
- `to`: `0x420000000000000000000000000000000000000F` (Gas Price Oracle Proxy)
- `mint`: `0`
- `value`: `0`
- `gasLimit`: `80,000`
- `gasLimit`: `90,000`
- `data`: `0x8e98b106`
- `sourceHash`: `0xbac7bb0d5961cad209a345408b0280a0d4686b1b20665e1b0f9cdafd73b19b6b`,
computed with the "Upgrade-deposited" type, with `intent = "Fjord: Gas Price Oracle Set Fjord"
Expand Down
6 changes: 6 additions & 0 deletions specs/fjord/exec-engine.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- [Fees](#fees)
- [L1-Cost fees (L1 Fee Vault)](#l1-cost-fees-l1-fee-vault)
- [Fjord L1-Cost fee changes (FastLZ estimator)](#fjord-l1-cost-fee-changes-fastlz-estimator)
- [FastLZ Implementation](#fastlz-implementation)
- [L1-Cost linear regression details](#l1-cost-linear-regression-details)
- [L1 Gas Usage Estimation](#l1-gas-usage-estimation)

Expand Down Expand Up @@ -45,6 +46,11 @@ Previously, `baseFeeScalar` and `blobFeeScalar` were used to encode the compress
the L1 cost function. However, the new cost function takes into account the compression ratio, so these scalars should
be adjusted to account for any previous compression ratio they encoded.

##### FastLZ Implementation

All compression algorithms must be implemented equivalently to this
[commit](https://github.com/ariya/FastLZ/commit/344eb4025f9ae866ebf7a2ec48850f7113a97a42).

##### L1-Cost linear regression details

The `intercept` and `fastlzCoef` constants are calculated by linear regression using a dataset
Expand Down
Loading

0 comments on commit 499210e

Please sign in to comment.