Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add World Chain Sepolia Testnet to the Superchain Registry #596

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

dianwen
Copy link
Contributor

@dianwen dianwen commented Sep 17, 2024

Adding a New Chain

This PR adds World Chain Sepolia Testnet to the registry.

Checklist

  • I have declared the chain at the appropriate Superchain Level.
  • I have run just validate <chain-id> locally to ensure all local validation checks pass.
  • I have run just codegen to ensure that the chainlist and other generated files are up-to-date and include my chain.

@dianwen dianwen requested a review from a team as a code owner September 17, 2024 15:24
@sbvegan
Copy link
Collaborator

sbvegan commented Sep 17, 2024

ethererum-lists pr: ethereum-lists/chains#5867

@sbvegan
Copy link
Collaborator

sbvegan commented Sep 17, 2024

Alchemy has let me know that they're going to activate Granite on this chain this week. We should hold off on the merging this PR until we have the granite activation time in here. Functionally I think the order of operations is to:

  1. Activate granite
  2. Update the configuration file
  3. Regenerate the registry artifacts with the just command
  4. Update this branch with the latest
  5. Validate the tests are passing
  6. Merge

@sbvegan sbvegan added F-do-not-merge Flag: Do Not Merge M-new-chain-request Meta: New Chain Request labels Sep 17, 2024
@dianwen
Copy link
Contributor Author

dianwen commented Sep 18, 2024

Public RPC URLs are correct now. Validation succeeds.

@sbvegan sbvegan removed the F-do-not-merge Flag: Do Not Merge label Sep 18, 2024
@sbvegan
Copy link
Collaborator

sbvegan commented Sep 18, 2024

@dianwen once you rebase this branch, we should be able to merge it

@bitwiseguy bitwiseguy merged commit 9d4ad3a into ethereum-optimism:main Sep 18, 2024
12 checks passed
@dianwen dianwen deleted the world-chain-sepolia branch September 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-new-chain-request Meta: New Chain Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants