Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-chain,validation: update dependency on optimism #599

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

geoknee
Copy link
Collaborator

@geoknee geoknee commented Sep 17, 2024

Brings in changes from ethereum-optimism/optimism#11830

@geoknee geoknee requested a review from a team as a code owner September 17, 2024 16:07
@geoknee
Copy link
Collaborator Author

geoknee commented Sep 17, 2024

Note that our diff bots are broken by recent changes to github actions permissions. But still we can see there is a diff generated by this PR https://github.com/ethereum-optimism/superchain-registry/actions/runs/10906969982/job/30269496423?pr=599 @bitwiseguy can you confirm this makes sense to you?

@bitwiseguy
Copy link
Collaborator

bitwiseguy commented Sep 17, 2024

@geoknee ChannelTimeoutGranite is now a constant within op-node as seen here. It is no longer included in the superchain or op-node rollup config structs so it should not be included in any of the chain configs produced by that tool

Copy link
Contributor

Detected nonzero diff in rollup config. This PR modifies the configuration of at least one chain in the registry, which may or may not have been intended. You can see the detail here.

@geoknee geoknee merged commit 55fac18 into main Sep 17, 2024
12 checks passed
@geoknee geoknee deleted the gk/update-optimism branch September 17, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants