Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC-721 and ERC-1155 to ERC-20 Wrapper #3384

Closed
ashrowz opened this issue Mar 14, 2021 · 4 comments
Closed

ERC-721 and ERC-1155 to ERC-20 Wrapper #3384

ashrowz opened this issue Mar 14, 2021 · 4 comments
Labels
discussions-to

Comments

@ashrowz
Copy link
Contributor

ashrowz commented Mar 14, 2021 •
edited
Loading

The following is a proposed EIP to wrap ERC-721 and ERC-1155 tokens with ERC-20. It will be submitted as a Draft once it has been revised according to community feedback. Questions of implementation are contained in Rationale.

The pull request is open here: #3386
@github-actions
Copy link

Since this is your first issue, we kindly remind you to check out EIP-1 for guidance.

ashrowz added a commit to ashrowz/EIPs that referenced this issue Mar 15, 2021
@ashrowz
Create EIP for a ERC-721, ERC-1155 to ERC-20 Wrapper (ethereum#3384)
bf7777a
lightclient added a commit that referenced this issue May 18, 2021
@ashrowz @lightclient
Create EIP for a ERC-721, ERC-1155 to ERC-20 Wrapper (#3386) (#3386)
01292a0 
* Create EIP for a ERC-721, ERC-1155 to ERC-20 Wrapper (#3384)

* Fixed EIP number (#3386)

* Fixed spelling

* Removed syntax errors.

* Upgraded interface to solidity v0.8.0, fixed typos, removed `_from` parameter from mints, added reference implementation

* Apply suggestions from code review

Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

* Added inline hyperlinks, removed unneeded list of links at the end.

* Simplified the abstract.

Co-authored-by: Calvin Koder <ashrwoz@mailbox.org>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
@github-actions
Copy link

There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Oct 24, 2021
@github-actions
Copy link

github-actions bot commented Nov 7, 2021

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this as completed Nov 7, 2021
@axic axic added discussions-to and removed stale labels Nov 11, 2021
@axic axic reopened this Nov 11, 2021
@ethereum ethereum deleted a comment Dec 4, 2021
@ethereum ethereum deleted a comment Dec 4, 2021
PhABC pushed a commit to PhABC/EIPs that referenced this issue Jan 25, 2022
@ashrowz @lightclient @PhABC
Create EIP for a ERC-721, ERC-1155 to ERC-20 Wrapper (ethereum#3386) (e…
465fbb7 
…thereum#3386)

* Create EIP for a ERC-721, ERC-1155 to ERC-20 Wrapper (ethereum#3384)

* Fixed EIP number (ethereum#3386)

* Fixed spelling

* Removed syntax errors.

* Upgraded interface to solidity v0.8.0, fixed typos, removed `_from` parameter from mints, added reference implementation

* Apply suggestions from code review

Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

* Added inline hyperlinks, removed unneeded list of links at the end.

* Simplified the abstract.

Co-authored-by: Calvin Koder <ashrwoz@mailbox.org>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
This was referenced May 31, 2022
Closed
Closed
@MicahZoltu
Copy link
Contributor

Since this EIP has become stagnant, we are closing this discussion issue for housekeeping purposes. You may continue discussion here on the closed issue (it won't be locked), but if you want to revive the EIP (bring it back to Draft or Review status), you will need to create a thread over at https://ethereum-magicians.org/ and update the discussions-to link in the EIP to point there instead (that is where all discussions happen now).

@ethereum ethereum locked and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
discussions-to
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@axic @MicahZoltu @ashrowz