-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How should we pick EIP numbers? #5294
Comments
This is a competing proposal, if not, at least relevant to #5082 |
Would like to add the following:
EDIT: Prototype done (https://github.com/Pandapip1/EIPNumberNFT) |
The perception is that "insiders" get treated differently rather than a consistent approach. PR/4444 didn't have its number changed even though PR/4439, PR/4440, PR/4441, PR/4442, PR/4443, were all opened within a minute of each other, in possible attempt to farm a number. PR/4844 didn't have its number changed even though PR/4843 was missing for unknown reasons. (GitHub can remove spam issues/PRs) PR/4888 number was changed to a non-PR number for a manually created PR for a too early draft PR/5000 was requested to change its number for a bot created PR with spam issues prior and another editor merged the PR later without a number change PR/5222 number was changed to a non-PR number My vote is for This doesn't preclude
|
@abcoathup while I 100% agree with your standpoint to make it less gamable and fairer, I don't think it would be trivial to maintain |
I, unfortunately, have volunteered to write and maintain whatever bot we agree on. |
@SamWilsn of course, huge respect! |
@Pandapip1 Was there a reason you didn't include a trustless/permissionless NFT sale option? I don't see any reason why editors should have privileged access when we could build the system to be 100% autonomous/permissionless. |
I'm generally against requiring all authors buy an NFT, so I think even if we did auction off old unused numbers we still would need a mechanism for number selection for people who didn't buy an NFT. For that problem, I like |
I thought that was implied. I'll make it explicit. |
It doesn't have to be perfectly resistant to tampering. It has to be more resistant to tampering that the current system which is clearly not resistant to tampering. |
Edited the EIP Number NFT option to include a better option (IMO). |
Yep, I forgot to write it down. I've added |
The previous iteration did have a method to allow this, but I've had a better idea. Edited to include this better idea. |
I'm against creating a ban list as it arguably won't work as number aestetic perception is subjective. E.g. the folks at Gnosis somehow got a palindrome 5005 while 5222 was argued away for being "too nice". As design criteria, I'd aim for making the number assignment as little arbitrary (no human decides) and as little human controllable (no human can hack) as possible. If beautiful numbers arise from this process and we can all agree it was just luck, that's good. |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
I think we've selected |
@SamWilsn just double checking this is the case? |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
This is in progress. |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback. |
In light of recent events, the discussion on how to assign numbers has come up again. This issue is solely for discussing assigning EIP numbers, and other topics will be deleted.
I'll try to summarize the proposals here, in preparation for the next EIPIP meeting. I'm going to give each proposal a
short-name
for easy reference.status-quo
seq-bot
N
in the commit when merging a Pull Request, whereN
is exactly one more than the largest existing EIP number.rand-bot
N
in the commit when merging a Pull Request, whereN
is equal to:R
plus the lowest unassigned EIP number andR
is a random number such that0 <= R < 100
; rerolling ifN
is an existing EIP.seq-rand-bot
N
in the commit when merging a Pull Request, whereN
is equal to: the largest existing EIP number plus a random integerR
, where0 < R < 11
.deny-list
status-quo
.The text was updated successfully, but these errors were encountered: