EIP-5218: NFT Rights Management #5222

iseriohn · 2022-07-11T23:14:20Z

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

eth-bot · 2022-07-11T23:14:58Z

All tests passed; auto-merging...

(pass) eip-5218.md

classification
`updateEIP`

passed!

(pass) assets/eip-5218/contracts/README.md

classification
`ambiguous`

file assets/eip-5218/contracts/README.md is associated with EIP 5218; because there are also changes being made to EIPS/eip-5218.md all changes to corresponding assets are also allowed

(pass) assets/eip-5218/contracts/foundry.toml

classification
`ambiguous`

file assets/eip-5218/contracts/foundry.toml is associated with EIP 5218; because there are also changes being made to EIPS/eip-5218.md all changes to corresponding assets are also allowed

(pass) assets/eip-5218/contracts/remappings.txt

classification
`ambiguous`

file assets/eip-5218/contracts/remappings.txt is associated with EIP 5218; because there are also changes being made to EIPS/eip-5218.md all changes to corresponding assets are also allowed

(pass) assets/eip-5218/contracts/src/IERC5218.sol

classification
`ambiguous`

file assets/eip-5218/contracts/src/IERC5218.sol is associated with EIP 5218; because there are also changes being made to EIPS/eip-5218.md all changes to corresponding assets are also allowed

(pass) assets/eip-5218/contracts/src/RightsManagement.sol

classification
`ambiguous`

file assets/eip-5218/contracts/src/RightsManagement.sol is associated with EIP 5218; because there are also changes being made to EIPS/eip-5218.md all changes to corresponding assets are also allowed

(pass) assets/eip-5218/contracts/test/Contract.t.sol

classification
`ambiguous`

file assets/eip-5218/contracts/test/Contract.t.sol is associated with EIP 5218; because there are also changes being made to EIPS/eip-5218.md all changes to corresponding assets are also allowed

(pass) assets/eip-5218/ic3license/ic3license.pdf

classification
`ambiguous`

file assets/eip-5218/ic3license/ic3license.pdf is associated with EIP 5218; because there are also changes being made to EIPS/eip-5218.md all changes to corresponding assets are also allowed

(pass) assets/eip-5218/ic3license/ic3license.tex

classification
`ambiguous`

file assets/eip-5218/ic3license/ic3license.tex is associated with EIP 5218; because there are also changes being made to EIPS/eip-5218.md all changes to corresponding assets are also allowed

(pass) assets/eip-5218/license-tree.png

classification
`ambiguous`

file assets/eip-5218/license-tree.png is associated with EIP 5218; because there are also changes being made to EIPS/eip-5218.md all changes to corresponding assets are also allowed

EIPS/eip-5222.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

…ights-Management into nft-rights-management

Pandapip1

Here's my first pass of this.

EIPS/eip-5218.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

EIPS/eip-5218.md

Pandapip1

A few licensing issues

assets/eip-5218/contracts/test/Contract.t.sol

assets/eip-5218/contracts/src/RightsManagement.sol

assets/eip-5218/contracts/src/IERC5218.sol

EIPS/eip-5218.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

EIPS/eip-5218.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

EIPS/eip-5222.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Co-authored-by: Micah Zoltu <micah@zoltu.net>

github-actions · 2022-07-20T18:04:16Z

The commit 6c7c875 (as a parent of 079c30f) contains errors. Please inspect the Run Summary for details.

Pandapip1

LGTM

* New EIP draft: NFT Rights Management * update eip identifier * Update EIPS/eip-5222.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * changing eip to 5218 * Update EIPS/eip-5218.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5218.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5218.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5218.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5218.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5218.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5218.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5218.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5218.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5218.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5218.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5218.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * modify external urls and add images and smart contracts * get rid of TODOs * Update assets/eip-5218/contracts/test/Contract.t.sol Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update assets/eip-5218/contracts/src/RightsManagement.sol Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update assets/eip-5218/contracts/src/IERC5218.sol Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * add github handle * Update EIPS/eip-5218.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * change eip number from 5218 to 5222 * fix EIPW Validator errors * fix EIPW Validator errors * add a paragraph on persistent license uri * add IC3 NFT License * Update EIPS/eip-5222.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5222.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * changing eip number from 5222 to 5218 Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> Co-authored-by: Micah Zoltu <micah@zoltu.net>

New EIP draft: NFT Rights Management

81fa42e

eth-bot added the ambiguous label Jul 11, 2022

update eip identifier

e3a3462

eth-bot added newEIPFile and removed ambiguous labels Jul 11, 2022

Pandapip1 reviewed Jul 12, 2022

View reviewed changes

EIPS/eip-5222.md Outdated Show resolved Hide resolved

iseriohn and others added 3 commits July 11, 2022 21:48

Update EIPS/eip-5222.md

c9e9aa2

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

changing eip to 5218

2dc209c

Merge branch 'nft-rights-management' of github.com:iseriohn/EIP-NFT-R…

eaae0d2

…ights-Management into nft-rights-management

Pandapip1 suggested changes Jul 12, 2022

View reviewed changes

iseriohn and others added 6 commits July 11, 2022 21:59

Update EIPS/eip-5218.md

359c0e9

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5218.md

25a4181

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5218.md

5186462

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5218.md

b5c4082

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5218.md

5ab6dd3

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5218.md

c115b11

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

poojaranjan mentioned this pull request Jul 12, 2022

EIP editor apprenticeship meeting 21 ethcatherders/EIPIP#154

Closed

iseriohn and others added 7 commits July 11, 2022 22:07

Update EIPS/eip-5218.md

c1f0d18

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5218.md

20f6547

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5218.md

59a9110

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5218.md

3dcf5df

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5218.md

c18b5b0

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5218.md

01d8fd6

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

modify external urls and add images and smart contracts

9a5eff4

eth-bot added the ambiguous label Jul 12, 2022

iseriohn changed the title ~~New EIP draft: NFT Rights Management~~ EIP-5218: NFT Rights Management Jul 12, 2022

get rid of TODOs

7f6bd5d

TimDaub reviewed Jul 13, 2022

View reviewed changes

EIPS/eip-5218.md Show resolved Hide resolved

Pandapip1 reviewed Jul 13, 2022

View reviewed changes

assets/eip-5218/contracts/test/Contract.t.sol Outdated Show resolved Hide resolved

assets/eip-5218/contracts/src/RightsManagement.sol Outdated Show resolved Hide resolved

assets/eip-5218/contracts/src/IERC5218.sol Outdated Show resolved Hide resolved

EIPS/eip-5218.md Show resolved Hide resolved

iseriohn and others added 3 commits July 14, 2022 00:49

Update assets/eip-5218/contracts/test/Contract.t.sol

52cefe1

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update assets/eip-5218/contracts/src/RightsManagement.sol

fde70c3

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update assets/eip-5218/contracts/src/IERC5218.sol

942061f

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

ethereum deleted a comment Jul 14, 2022

MicahZoltu reviewed Jul 14, 2022

View reviewed changes

EIPS/eip-5218.md Outdated Show resolved Hide resolved

iseriohn and others added 2 commits July 14, 2022 12:16

add github handle

e9854df

Update EIPS/eip-5218.md

ad79fbe

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

iseriohn changed the title ~~EIP-5218: NFT Rights Management~~ EIP-5222: NFT Rights Management Jul 18, 2022

iseriohn added 4 commits July 18, 2022 10:53

change eip number from 5218 to 5222

d960b35

fix EIPW Validator errors

93c9113

fix EIPW Validator errors

fe240c1

add a paragraph on persistent license uri

f852fd9

lightclient mentioned this pull request Jul 18, 2022

Delete EIP-5000 #5255

Closed

abcoathup mentioned this pull request Jul 20, 2022

How should we pick EIP numbers? #5294

Closed

add IC3 NFT License

403ab32

Pandapip1 reviewed Jul 20, 2022

View reviewed changes

EIPS/eip-5222.md Outdated Show resolved Hide resolved

MicahZoltu reviewed Jul 20, 2022

View reviewed changes

EIPS/eip-5222.md Outdated Show resolved Hide resolved

Pandapip1 reviewed Jul 20, 2022

View reviewed changes

EIPS/eip-5222.md Outdated Show resolved Hide resolved

iseriohn and others added 2 commits July 20, 2022 13:42

Update EIPS/eip-5222.md

4ab2a07

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5222.md

6c7c875

Co-authored-by: Micah Zoltu <micah@zoltu.net>

iseriohn changed the title ~~EIP-5222: NFT Rights Management~~ EIP-5218: NFT Rights Management Jul 20, 2022

changing eip number from 5222 to 5218

1547507

Pandapip1 approved these changes Jul 20, 2022

View reviewed changes

eth-bot added updateEIP and removed newEIPFile labels Jul 20, 2022

kodiakhq bot merged commit b4ffd22 into ethereum:master Jul 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EIP-5218: NFT Rights Management #5222

EIP-5218: NFT Rights Management #5222

iseriohn commented Jul 11, 2022

eth-bot commented Jul 11, 2022 •

edited

Loading

Pandapip1 left a comment

Pandapip1 left a comment

github-actions bot commented Jul 20, 2022

Pandapip1 left a comment

EIP-5218: NFT Rights Management #5222

EIP-5218: NFT Rights Management #5222

Conversation

iseriohn commented Jul 11, 2022

eth-bot commented Jul 11, 2022 • edited Loading

All tests passed; auto-merging...

(pass) eip-5218.md

(pass) assets/eip-5218/contracts/README.md

(pass) assets/eip-5218/contracts/foundry.toml

(pass) assets/eip-5218/contracts/remappings.txt

(pass) assets/eip-5218/contracts/src/IERC5218.sol

(pass) assets/eip-5218/contracts/src/RightsManagement.sol

(pass) assets/eip-5218/contracts/test/Contract.t.sol

(pass) assets/eip-5218/ic3license/ic3license.pdf

(pass) assets/eip-5218/ic3license/ic3license.tex

(pass) assets/eip-5218/license-tree.png

Pandapip1 left a comment

Choose a reason for hiding this comment

Pandapip1 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 20, 2022

Pandapip1 left a comment

Choose a reason for hiding this comment

eth-bot commented Jul 11, 2022 •

edited

Loading