Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique tokens system to prevent forging tokens. #722

Closed
patpat8 opened this issue Sep 27, 2017 · 8 comments
Closed

Unique tokens system to prevent forging tokens. #722

patpat8 opened this issue Sep 27, 2017 · 8 comments
Labels

Comments

@patpat8
Copy link

patpat8 commented Sep 27, 2017

ATTENTION! If you would like to submit an EIP and it has already been written as a draft (see the template for an example), please submit it as a Pull Request.

If you are considering a proposal but would like to get some feedback on the idea before submitting a draft, then continue opening an Issue as a thread for discussion. Note that the more clearly and completely you state your idea the higher the quality of the feedback you are likely to receive.

Keep in mind the following guidelines from EIP-1:

Each EIP must have a champion - someone who writes the EIP using the style and format described below, shepherds the discussions in the appropriate forums, and attempts to build community consensus around the idea. The EIP champion (a.k.a. Author) should first attempt to ascertain whether the idea is EIP-able. Posting to the the Protocol Discussion forum or opening an Issue is the best way to go about this.

Vetting an idea publicly before going as far as writing a EIP is meant to save the potential author time. Asking the Ethereum community first if an idea is original helps prevent too much time being spent on something that is guaranteed to be rejected based on prior discussions (searching the Internet does not always do the trick). It also helps to make sure the idea is applicable to the entire community and not just the author. Just because an idea sounds good to the author does not mean it will work for most people in most areas where Ethereum is used.

Once the champion has asked the Ethereum community as to whether an idea has any chance of acceptance, a draft EIP should be presented as a Pull Request. This gives the author a chance to flesh out the draft EIP to make properly formatted, of high quality, and to address initial concerns about the proposal.

@patpat8
Copy link
Author

patpat8 commented Sep 27, 2017

It is very easy for anyone to create an exact copy of a pre existing coin. Take for example ATC token.
The same token can be identified by these 3 addresses :

https://etherscan.io/token/0x7ce88ceed1015ecebaed624459dd97435e77157b

https://etherscan.io/token/0xeaac5d6beab6f1b214152c8201ad1111028e6a1a

https://etherscan.io/token/0x379ca5d5f053f92a60388f4ca748060c6f6664b2

I am aware of the fact that there is an additional ✓ mark to signify the correct token but in case of direct trading between peers if the receiver has not received any tokens before can be misguided to believe what is being sent is legit one.

I hope you understand what I am saying if further clarification is required , then let me know.
Thanks.

@MicahZoltu
Copy link
Contributor

Do you have a proposal to address this perceived problem? The issue body is missing.

@patpat8
Copy link
Author

patpat8 commented Sep 28, 2017

Oops that's embarrassing. Actually this was my 1st ever issue reporting on GitHub. :)

I currently do not have an exact proposal to solve this issue because I am not familiar with the underlying code .
It may be possible that whenever there is a new Token Contract being created , a method should be called that runs through database of pre-existing tokens and validates that the Name & Symbol being used is not already taken.

Point is to disallow creation of a new token which contain Exactly the same "Name" and "Symbol' of previously existing token.

For ex. If there is a ABCD coin already existing as a token with Symbol ABCD no-one else should be able to create another "ABCD coin" sym: "ABCD" .

I think it's a much needed censorship that has to be brought .

I hope I am clear with the issue part. How to solve it I am not completely sure.

@MicahZoltu
Copy link
Contributor

Ethereum is all about censorship resistance, and no one has more of a right to a token name/symbol that anyone else. ENS provides a first-come-first-serve-ish mechanism for buying/renting namespaces, but I'm not sure there is value in embedding a complex auction/rent system like that into tokens.

In general, I suspect an EIP that attempts to limit freedom of choice for token names/symbols is likely to result in quite a bit of push back, especially since there are only ~17,000 3 letter symbols which means they'll be all bought up really fast in whatever auction system you had and then likely squated on.

@shrugs
Copy link

shrugs commented Sep 28, 2017

There shouldn't be an enforced central list of tokens. There are many lists of well-known tokens, to solve the issue you described. Enforcing this sort of thing goes against the ethos of ethereum, and also doesn't seem actually possible, since tokens are not a native construct; they're just smart contracts with balances.

moving to close

@patpat8
Copy link
Author

patpat8 commented Sep 28, 2017

I understand your concern and practicality issue.
Close this issue if you feel so.
Thanks.

@github-actions
Copy link

github-actions bot commented Jan 2, 2022

There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Jan 2, 2022
@github-actions github-actions bot removed the stale label Jan 12, 2022
@ethereum ethereum deleted a comment from d-sfounis Jan 13, 2022
@github-actions
Copy link

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

Woodpile37 added a commit to Woodpile37/EIPs that referenced this issue Nov 2, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to fix one or more
vulnerable packages in the `npm` dependencies of this project.</h3>



#### Changes included in this PR

- Changes to the following files to upgrade the vulnerable dependencies
to a fixed version:
    - assets/eip-4675/package.json



#### Vulnerabilities that will be fixed
##### With an upgrade:
Severity | Issue | Breaking Change | Exploit Maturity

:-------------------------:|:-------------------------|:-------------------------|:-------------------------
![medium
severity](https://res.cloudinary.com/snyk/image/upload/w_20,h_20/v1561977819/icon/m.png
"medium severity") | Open Redirect
<br/>[SNYK-JS-GOT-2932019](https://snyk.io/vuln/SNYK-JS-GOT-2932019) |
No | No Known Exploit




<details>
  <summary><b>Commit messages</b></summary>
  </br>
  <details>
    <summary>Package name: <b>solidity-coverage</b></summary>
    The new version differs by 41 commits.</br>
    <ul>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/0a33e13b166651bf8ce94d425d0abf590fed784c">0a33e13</a>
0.8.0</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/4c63612f83f6b230810f5728f4c1315cfe28cef2">4c63612</a>
Add hardhat to peerDependencies (ethereum#722)</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/9ce20ff4bbc3c7e015ac0a5574cc1ab61cfc216b">9ce20ff</a>
Typo / Grammar fix. (ethereum#738)</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/204a5ebaa4be69fd420f9d3851dd518d9072ece9">204a5eb</a>
Added a section for the report location. (ethereum#739)</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/ed3d5041764e1b6a2270d0b910a3bfaf1a9d3c01">ed3d504</a>
Fix README for v0.8 release</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/05ab320fbccb7bc607d9e5ada4a3261c46a273e8">05ab320</a>
Fixes for Hardhat 2.11.0 (ethereum#740)</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/bc7d07623ec4bd71a2ce4c8ecb4a872af613c8ef">bc7d076</a>
0.8.0 Additional Coverage Measurements &amp; Restructure (Merge)</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/a7db2fedc447f318da0424a162e58a2475072dc1">a7db2fe</a>
More README changes</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/16367d15389ade4f8cc5d9c17ccac2cfd0962e14">16367d1</a>
Remove truffle files from project</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/26898c1ad9f81ae089953fa0a824ab01b7caef08">26898c1</a>
Remove Builder-E2E test</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/8ea8ec93d923a9722a3549e5788d5aaa81b3a41a">8ea8ec9</a>
Fix true/false scoped method definition function visibilities</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/21ca46e2de3e1fe27d120b38fe7383a0a90792b1">21ca46e</a>
Temporarily skip truffle integration tests</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/22992e1c19825d27de665762ffb8798a6b3195fe">22992e1</a>
Fix constructor test</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/cf126ea7311145214fde7f7538bf4428e168b834">cf126ea</a>
Fix assert tests</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/0ba3f11701097693674dab8cf831fac9af113fb0">0ba3f11</a>
Remove more buildler things</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/d57a1315ec73ee0f0a26a2e64212a6055d51c3ab">d57a131</a>
Remove buidler</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/3bcec941ecbeac2fd385c3e17886e7e02c66c2ad">3bcec94</a>
Fix rebase errors &amp; regenerate yarn.lock</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/88c1d0039033cfbb38311c6430ebdc41d5480c03">88c1d00</a>
Fix loops, modifiers, options and statements tests</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/0deb0013cbf9e552a133c18d46e4b6536700982f">0deb001</a>
Fix if/else tests</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/29c0fdda7fcc438861bcbb4ad1c0cb26ffbd08fb">29c0fdd</a>
Fix constructor keyword test</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/d4e8536aa3087f40853f2b4c168dfa2b4e9c6e7a">d4e8536</a>
Update tests for adjusted statement coverage</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/3edfd2537180e0f78ba769b077664a3159ba0b2a">3edfd25</a>
Stop injecting statement coverage into conditionals</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/7eb94a93f3b2a2c68535051758c688470de9a1e2">7eb94a9</a>
Update @ solidity-parser/parser to 0.14.1</li>
<li><a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/commit/e9133d719ca3969b63ffa777a13a3424f886fbc8">e9133d7</a>
Generate mocha JSON output with --matrix (ethereum#601)</li>
    </ul>

<a
href="https://snyk.io/redirect/github/sc-forks/solidity-coverage/compare/0e17f18e80e46c598097ab89e32379cb6ffd7e33...0a33e13b166651bf8ce94d425d0abf590fed784c">See
the full diff</a>
  </details>
</details>






Check the changes in this PR to ensure they won't cause issues with your
project.



------------



**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open fix PRs.*

For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiI5MjU1NWU1OC1iZGQ2LTQ5MjctOWVlMy1hZDlkMTE1NDFmNWIiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjkyNTU1ZTU4LWJkZDYtNDkyNy05ZWUzLWFkOWQxMTU0MWY1YiJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/woodpile37/project/f0dcf1c9-ecf1-445b-bc07-e8f73c595f54?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;fix-pr)

🛠 [Adjust project
settings](https://app.snyk.io/org/woodpile37/project/f0dcf1c9-ecf1-445b-bc07-e8f73c595f54?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;fix-pr/settings)

📚 [Read more about Snyk's upgrade and patch
logic](https://support.snyk.io/hc/en-us/articles/360003891078-Snyk-patches-to-fix-vulnerabilities)

[//]: #
(snyk:metadata:{"prId":"92555e58-bdd6-4927-9ee3-ad9d11541f5b","prPublicId":"92555e58-bdd6-4927-9ee3-ad9d11541f5b","dependencies":[{"name":"solidity-coverage","from":"0.7.22","to":"0.8.0"}],"packageManager":"npm","projectPublicId":"f0dcf1c9-ecf1-445b-bc07-e8f73c595f54","projectUrl":"https://app.snyk.io/org/woodpile37/project/f0dcf1c9-ecf1-445b-bc07-e8f73c595f54?utm_source=github&utm_medium=referral&page=fix-pr","type":"auto","patch":[],"vulns":["SNYK-JS-GOT-2932019"],"upgrade":["SNYK-JS-GOT-2932019"],"isBreakingChange":false,"env":"prod","prType":"fix","templateVariants":["updated-fix-title"],"priorityScoreList":[null],"remediationStrategy":"vuln"})

---

**Learn how to fix vulnerabilities with free interactive lessons:**

🦉 [Open
Redirect](https://learn.snyk.io/lesson/open-redirect/?loc&#x3D;fix-pr)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants