ERC Proxy Identity draft #1036
ERC Proxy Identity draft #1036
Conversation
EIPS/eip-X-identity.md
Outdated
| @@ -0,0 +1,302 @@ | |||
| --- | |||
| eip: <to be assigned> | |||
There was a problem hiding this comment.
Please rename to eip-725.md and number 725.
EIPS/eip-X-identity.md
Outdated
| @@ -0,0 +1,302 @@ | |||
| --- | |||
| eip: <to be assigned> | |||
| title: ERC-725 Identity | |||
There was a problem hiding this comment.
No need to include the EIP/ERC number in the title.
There was a problem hiding this comment.
I would also argue that the title is a bit broad.
There was a problem hiding this comment.
I renamed it to Proxy Identity to be more specific
EIPS/eip-X-identity.md
Outdated
| --- | ||
| eip: <to be assigned> | ||
| title: ERC-725 Identity | ||
| author: Fabian Vogelsteller (@frozeman) <fabian@ethereum.org> |
There was a problem hiding this comment.
I don't think the build script will know how to parse this into a single link.
Either GitHub username or e-mail address should be sufficient.
See: https://github.com/ethereum/EIPs/blob/master/_includes/authorlist.html
|
Please rename to |
|
Also, see the build failure- you have an invalid internal link in your document. |
|
Why not adding the title in the md document name, like we have for ERC20: |
|
@frozeman Because that's not the naming convention we use for merged drafts. |
|
@frozeman Those two drafts should never have been merged as-is. Thanks for pointing it out, I've fixed them. |
This PR adds the ERC identity draft with slight modifications to the discussed #725.
Once this PR is merged we can discuss specific changes by making separate PRs to the draft itself.
Following modifications are present:
I removed the
getKeyPurposesin favour ofkeyHasPurpose, which returns a bool and will work as a check for checking keys at an identity.I also changed the key structure to keep an array of purpose IDs in the struct of the key, but we should discuss the idea of @nick to use a bit mask instead for storing purposes later.