Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token metadata json schema #1047

Merged
merged 19 commits into from
May 6, 2018

Conversation

tomasienrbc
Copy link
Contributor

Initial pull request for the "Token Metadata Standard" EIP.

The goal of this EIP is to create a standard interface for token metadata, inspired by the ERC721 Token Metadata standard. With the addition of the ERC20 Metadata Extension EIP, it makes more sense to maintain a separate "Token Metadata Standard" rather than updating the metadata standard in multiple places (ERC20, ERC721, etc).

EIPS/eip-721.md Outdated
@@ -186,13 +186,13 @@ interface ERC721Metadata /* is ERC721 */ {

/// @notice A distinct Uniform Resource Identifier (URI) for a given asset.
/// @dev Throws if `_tokenId` is not a valid NFT. URIs are defined in RFC
/// 3986. The URI may point to a JSON file that conforms to the "ERC721
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't include changes to unrelated files in your PR.

@@ -0,0 +1,72 @@
---
eip: <to be assigned>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please number this 1047, and rename to eip-1047.md.

eip: <to be assigned>
title: Token Metadata JSON Schema
author: Tommy Nicholas (@tomasienrbc), Matt Russo (@mateosu), John Zettler (@JohnZettler)
discussions-to: thelab@rareart.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a mailing list or discussion forum URL.

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

No changes to ERC721 in this PR
@tomasienrbc
Copy link
Contributor Author

@Arachnid fixed the fact that there were unintentional ERC721 changes in this PR stopping it from being auto-merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants