Token metadata json schema #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nearly ready for comments by Matt, Matt, and John
- Added initial “Token Metadata JSON Schema” - Re-named “ERC721 Metadata JSON Schema” to “Token Metadata JSON Schema” in the ERC721 EIP
Apparently Github handles for authors are meant to be “accurate” - who knew?
…ns which are not NFT's. Added clarification for backwards compatibility
This branch is going to be just the Token Metadata Standard
Arachnid
reviewed
Apr 29, 2018
EIPS/eip-721.md
Outdated
| @@ -186,13 +186,13 @@ interface ERC721Metadata /* is ERC721 */ { | |||
|
|
|||
| /// @notice A distinct Uniform Resource Identifier (URI) for a given asset. | |||
| /// @dev Throws if `_tokenId` is not a valid NFT. URIs are defined in RFC | |||
| /// 3986. The URI may point to a JSON file that conforms to the "ERC721 | |||
There was a problem hiding this comment.
Please don't include changes to unrelated files in your PR.
| @@ -0,0 +1,72 @@ | |||
| --- | |||
| eip: <to be assigned> | |||
There was a problem hiding this comment.
Please number this 1047, and rename to eip-1047.md.
| eip: <to be assigned> | ||
| title: Token Metadata JSON Schema | ||
| author: Tommy Nicholas (@tomasienrbc), Matt Russo (@mateosu), John Zettler (@JohnZettler) | ||
| discussions-to: thelab@rareart.io |
There was a problem hiding this comment.
Please provide a mailing list or discussion forum URL.
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
No changes to ERC721 in this PR
|
@Arachnid fixed the fact that there were unintentional ERC721 changes in this PR stopping it from being auto-merged. |
This was referenced May 9, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial pull request for the "Token Metadata Standard" EIP.
The goal of this EIP is to create a standard interface for token metadata, inspired by the ERC721 Token Metadata standard. With the addition of the ERC20 Metadata Extension EIP, it makes more sense to maintain a separate "Token Metadata Standard" rather than updating the metadata standard in multiple places (ERC20, ERC721, etc).