EIP-1191: extends EIP-55 by optionally adding a chain id defined by EIP-155 to the checksum calculation #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arachnid
reviewed
Jul 5, 2018
EIPS/eip-1186.md
Outdated
| @@ -0,0 +1,97 @@ | |||
| --- | |||
| eip: 1186 | |||
There was a problem hiding this comment.
Why is this numbered 1186?
There was a problem hiding this comment.
Tell me what number to use. 1191?
juli
changed the title
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Jul 19, 2018
…IP-155 to the checksum calculation (ethereum#1191) * EIP Add chain id to mixed-case checksum address encoding * Fixes header * Update eip-1186.md * Change assigned EIP number
|
@juli this EIP doesn't have a copyright statement. Can you please add one? EIP-1 suggests CC0 - see the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.